sociallogin.is_existing fails if existing user associated in adapter.new_user about django-allauth

[banagale]

I wanted to add that our social app, the only one we're supporting is SAML.

I see that #3997 resulted in SOCIALACCOUNT_EMAIL_AUTHENTICATION_AUTO_CONNECTS getting added, which seems like perhaps the intent now is to use this to perform the connection I'm doing in new_user?

[pennersr]

new_user() is instantiating a new/blank User instance. it is supposed to be unsaved -- there shouldn't be any user.pk set.

Has the method for linking up an existing user account with a social login changed?

No

If a real user should not be attached at the time FinishACSView runs, when should it be attached?

The adapter.pre_social_login() would be a good place. At this point, allauth ran all its logic, and it is clear whether or not the social account and/or the user are known.