Coder Social home page Coder Social logo

Comments (6)

shacharz avatar shacharz commented on August 22, 2024

It needs the dependency to support old browsers that hls.js can play on, and they require flash to play HLS. So in case hls.js's .isSupported() returns false it can fallback to the videojs-contrib-hls code to do it's thing.
Having said that, it can be interesting to load it async only on demand.

from videojs-contrib-hls.js.

boushley avatar boushley commented on August 22, 2024

I'd consider removing that as a dependency entirely. That seems like something that developers using this plugin could do, without adding the 162kb of code to each distribution.

For my use case I don't need or want any Flash fallback, so I'll have to rely on a custom build that doesn't include that fallback.

from videojs-contrib-hls.js.

saarangsoltani avatar saarangsoltani commented on August 22, 2024

+1 for removing the extra dependancy. We are opting for this plugin as a replacement for the original videojs-contrib-hls as the media errors are not handled properly by that and it does not make much sense to still carry that around. I think using Flash as a fallback handler for HLS should be left to the developer not to mention the fact that Flash is deprecated and Google is panning to block Adobe Flash and implement an 'HTML5 by Default' policy on Chrome by the end of 2016. The intention is to use HTML5 automatically, and force users to explicitly accept the use of Flash only where there is no other choice.

from videojs-contrib-hls.js.

shacharz avatar shacharz commented on August 22, 2024

I think it's a good idea, but I think it should be opt-out. Since that's the expectations for videojs-contrib-hls and we wouldn't want to break that behavior.
How about an additional build?

from videojs-contrib-hls.js.

JonAlpha avatar JonAlpha commented on August 22, 2024

Another build is a better idea. You still have users on old IE browsers

from videojs-contrib-hls.js.

shacharz avatar shacharz commented on August 22, 2024

see #15

from videojs-contrib-hls.js.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.