Coder Social home page Coder Social logo

Comments (11)

fkuehne avatar fkuehne commented on September 26, 2024

I'm having a look at this right now. For me, it doesn't work at all and results in nice libvlc crashes because we give it an empty VLCMedia.

I'll provide some fix for this later tonight and will have a look at the command line. VLC is definitely able to create quicktime-compliant mp4 files.

from glasses.

fkuehne avatar fkuehne commented on September 26, 2024

Okay, it probably doesn't work for you right now because the current contribs don't include a usable mp4a encoder (aka faad) due to licensing issues.

Exporting to MPEG2 works correctly (mostly, note that only few framerates are supported here), but libvlc fails to report EOF of the input correctly. Therefore, the progressbar stalls at about 33 %. Canceling the dialog will finish the file.

from glasses.

pdherbemont avatar pdherbemont commented on September 26, 2024

Hmm. So far, we need to open a ticket to track the issue you are talking about in libvlc.

Also, does this mean that we can't properly export to mp4? I think that's what we want to be able to export to, and not mpeg2...

from glasses.

fkuehne avatar fkuehne commented on September 26, 2024

Yes, that's correct. VLC 1.0 and later no longer include a working mp4a encoder and therefore fail to output correct MP4 files. I met one of the FFmpeg developers at LinuxTag this June and he told me that some folks are working on a licensing compliant encoder, but I don't really know how far they got. Reportedly, it is a lot slower and doesn't include all profiles (yet?).

Exporting to MPEG2 is definitely unimportant for most users and should be removed again later on.

The EOF thing is definitely a libvlc issue. This also explains why [VLCStreamSession.isComplete] never turns true.

from glasses.

pdherbemont avatar pdherbemont commented on September 26, 2024

ok :( I'll have a look at the libvlc side.

from glasses.

fkuehne avatar fkuehne commented on September 26, 2024

Hum, according to Mans from FFmpeg, their native AAC encoder is not under active development anymore. At present, it is not useable, as modern PCs are unable to encode stuff in real time with it. There are plans to audit the faac encoder though and to revive it in a fully LGPL compatible way.

For the meantime, I'll have a look at the Handbrake project. Their latest release includes a QuickTime based encoder (which they call "CoreAudio"-based). Perhaps, it can be used here, too?

from glasses.

pdherbemont avatar pdherbemont commented on September 26, 2024

Good idea. That said, we are GPL, do we care about including GPL code? (ffac is GPL, I think that's the issue with ffmpeg). We could ask for legal hint there.

from glasses.

pdherbemont avatar pdherbemont commented on September 26, 2024

Any update on this? Are we dropping the feature?

from glasses.

fkuehne avatar fkuehne commented on September 26, 2024

Hmm, I've got a non-working draft of a CoreAudio-based encoder module for VLC. It's unfinished work, but I could share it if you're interested. That would probably the best way to go, as it would add all available (audio) encoders to VLC. However, I've got absolutely no time to work on it right now, which is a pity.
Dropping the feature wouldn't be great IMO, as from a user's perspective, I'd expect it to be there.

from glasses.

gmthor avatar gmthor commented on September 26, 2024

Just curious. Since Lunette is Mac OS X only, wouldn't it make sense to use CoreAudio for encoding/decoding AAC? I remember that there was an XCode example ( name: afconvert ) that could encode AAC with CoreAudio.
Or do you plan to keep stuff like that in the VLCKit framework?

from glasses.

pdherbemont avatar pdherbemont commented on September 26, 2024

It would make sense to use CoreAudio and QTKit where appropriate. But we don't have a lot of choice, we need to have it as a VLC module.

from glasses.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.