Coder Social home page Coder Social logo

Comments (3)

tomaz-suller avatar tomaz-suller commented on September 15, 2024

Apesar de não conseguir reproduzir a issue exatamente como descrito, o montador deveria emitir uma mensagem de erro mesmo, e ele não emite, então essa parte consegui reproduzir.


Só pra deixar registrado, o comportamento atual tentando montar o seguinte exemplo:

FOO LV /0
FOO LV /1
BAR LD FOO

é

$ cargo run --bin mvn-cli -- assemble -i example.asm
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/mvn-cli assemble -i example.asm`
0000 3000
0002 3005
0004 8002

from mvn-rs.

tomaz-suller avatar tomaz-suller commented on September 15, 2024

O conserto vai ser adicionar mais um caso de validação no validator.rs do montador, e claro testes pra garantir que a gente não regrida pra esse caso de novo.

Deve ser bem direto.

from mvn-rs.

tomaz-suller avatar tomaz-suller commented on September 15, 2024

Na verdade vai ser mais complexo do que isso porque hoje só existem validações de linha, não validações de arquivo todo:

pub fn validate<'a, 'b>(
program: &'a AddressedProgram<'b>,
label_map: &'a LabelMap<'b>,
) -> ValidatorResult<'b> {
for line in program.lines.iter() {
let validator = LineValidator::new(&line.line, &line.address, label_map);
validator.validate()?;
}
Ok(())
}
struct LineValidator<'a, 'b> {
line: &'a Line<'b>,
address: &'a Address,
label_map: &'a LabelMap<'b>,
}

Vamos precisar implementar um ProgramValidator também para verificar essas e outras condições de erro que só conseguimos detectar analisando o arquivo todo (como #19)

from mvn-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.