updates for mip-cmor-tables about cmor

[durack1]

Just linking across repos so we don't miss fixes
cmip-ipo-internal/CVTool#16

[durack1]

This is a dupe of #718 - so both should be closed when the 3.8.0 changes are in place

[mauzey1]

As mentioned in the mip-cmor-tables wiki, the modeling_realm attribute in variable entries will become a list instead of a string. We want to concatenate the values in that list into a string of values separated by spaces.

["ocean", "land"] -> "ocean land"

The changes that I made to turn the list of dimensions into a space-separated list string also applies this change to the modeling realm values. However, when I tried creating a NetCDF file where the modeling_realm attribute had multiple values I only got the first value saved to the NetCDF file. This is being caused by the following code.

cmor/Src/cmor.c

Lines 2941 to 2952 in 047fd2c

	if (cmor_tables[nVarRefTblID].vars[ref_var_id].realm[0] != '\0') {
	szToken = strtok(cmor_tables[nVarRefTblID].vars[ref_var_id].realm, " ");
	if (szToken != NULL) {
	cmor_set_cur_dataset_attribute_internal(GLOBAL_ATT_REALM,
	szToken, 0);
	} else {
	cmor_set_cur_dataset_attribute_internal(GLOBAL_ATT_REALM,
	cmor_tables
	[nVarRefTblID].vars
	[ref_var_id].realm, 0);
	}
	} else {

I'm not sure why it was decided to only use the first value in a list of realms. Should this be removed so that every value in the list is included?

@durack1 @matthew-mizielinski

[durack1]

@mauzey1 this seems like another bug. The realm is not being used in either the DRS/directory or filename (the table_id captures this info and is included in both) so should be written out to the file as provided by the table entries