vMotion Issue about vspc.py

[xuguanghan]

function _handle_vmotion_begin has a bug. try change to 👍

def _handle_vmotion_begin(self, data):
    cookie = data + struct.pack("l", hash(self) & 0xFFFFFFFF)
    if self.handler.handle_vmotion_begin(self, cookie):
        logging.debug("vMotion initiated: %s" % hexdump(cookie))
        self._send_vmware(VMOTION_GOAHEAD + cookie)
    else:
        logging.debug("vMotion denied: %s" % hexdump(cookie))
        self._send_vmware(VMOTION_NOTNOW + cookie)

[nicobbg]

I confirm this issue.

Running ESXi 5.5u3, I have a cluster of 2 ESXi and when I try to migrate a VM with a serial port configured for the vSPC server it fails.

This does not happen with other VM with a serial port configured on an Avocent (a commercial virtual serial port concentrator)

Error output:

A general system error occurred: Migration to host <> failed with error Connection closed by remote host, possibly due to timeout (0xbad003f).
Migration to host <> failed with error Connection closed by remote host, possibly due to timeout (195887167).
vMotion migration [-1062076156:1476173590574550] failed to send init message to the remote host <>
vMotion migration [-1062076156:1476173590574550] (0-71743133716968) failed to receive 68/68 bytes from the remote host <>: Connection closed by remote host, possibly due to timeout
The vMotion failed because the destination host did not receive data from the source host on the vMotion network. Please check your vMotion network settings and physical network configuration and ensure they are correct.

[nicobbg]

I confirmed that the patch mentionned by xuguanghan is fixing the issue.
This issue is also a duplicate with issue #17. Can you fix this issue and merge it with master ?

[pbhenson]

Fixed in master.