Coder Social home page Coder Social logo

Comments (5)

jacobsfletch avatar jacobsfletch commented on July 21, 2024 1

@glettl I just opened PR #39 for this, let me know what you think!

from plugin-form-builder.

jacobsfletch avatar jacobsfletch commented on July 21, 2024

Hey @glettl what you're describing makes sense to me. And you're right, we should allow for additions to made to the fields within each block not just the block itself. But I think the API could be simpler than what you propose, we're already merging the partial block config in with the plugin's default block, so it sounds like we just need to take this one step further and merge the fields within the block, too.

fields: {
  email: {
    fields: [...] // merge this instead of replace
  }
}

What do you think of this?

from plugin-form-builder.

jacobsfletch avatar jacobsfletch commented on July 21, 2024

I know that there are cases where one wants to redefine all form-fields, however it would be nice if a way to simply add custom fields to an form-field could be provided.

Yep ok I see exactly why you proposed your two solutions. Either add a flag to set the merge strategy, or import the fields to merge them yourself. It does feel like merge should have been the default, but definitely don't want to introduce breaking changes. So let's just export the fields like you propose (option 2) this way we don't have to change the API at all.

from plugin-form-builder.

jacobsfletch avatar jacobsfletch commented on July 21, 2024

This was just published in 1.0.14-canary.0 🎉

from plugin-form-builder.

jacobsfletch avatar jacobsfletch commented on July 21, 2024

And now v1.0.14 🚀

from plugin-form-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.