[y_commands]Command_AddAltNamed special characters about ysi-includes

[Misiur]

I'm not certain what the cause is, it might either be PAWN specific, y_hashmap limitaton, or something completely different. I don't have much time lately, so I'm not certain if I'll get around to it. Also, do you know if this bug was present in YSI 3?

[Misiur]

Found it: This is the root cause.

[Y-Less]

I don't actually think that's the root cause. I've only had a quick glance since I'm trying to help less and just encourage others to get to know the code, but looking at it this is my fault. "Command_AddAlt" hashes the string (using bernstein, that comment you highlighted only applies for compile-time string hashes and the first character of a string at run-time), but "Command_ReProcess" does a slightly different hash. It converts:

rádióhangolás

To:

rdihangols@s4ai1u

Using standard punycode, but with "@" instead of "-", while hashing that result. So "Command_AddAlt" needs to do that encoding instead. This is because y_commands has a feature so secret that even I forgot about it! You can declare commands with punycode:

YCMD:rdihangols@s4ai1u(playerid, params[], help)
{
}

Is equivalent to:

YCMD:rádióhangolás(playerid, params[], help)
{
}

But will compile.

[Y-Less]

There are punycode converters online, but most will prefix the result with "xn--" and separate the two parts with "-", because that is how they are used in internationalised domain names.

[Misiur]

Welp, I'm wrong again. Being puny human ain't easy. So, applying Puny_EncodeHash into addalt is the way to go?

[Y-Less]

Probably, as I said that was just a cursory glance.

[MadRoxx]

Hello again, i tested with This version of YSI and now works.

[Misiur]

Ok, just keep in mind that master is 3, and there are many improvements in 4 (though as we can see with occasional bugs). Keep an eye on this issue, and upgrade when we resolve this.

[MadRoxx]

Ok, i wait for updates, and thanks for the help :)

[MadRoxx]

something? ❓

[Misiur]

Well, I tried a lot of stuff today, but I can't seem to get it working properly. One major problem is with Command_Find, as from simple hashmap lookup it went to

foreign Command_Find(string:cmd[]);

global Command_Find(string:cmd[])
{
    static
        sCmd[64] = "",
        sHash;

    Puny_EncodeHash(sCmd, cmd, sHash, .delimiter = '@');

    return HashMap_GetWithHash(YSI_g_sCommandMap, sCmd, sHash);
}

This is not something we want for every command lookup (performance wise). I'll fiddle with it some more tommorow, maybe I've overlooked something.

[Misiur]

Ok, tests pass so I guess Misiur@e0a9051 solves this for you. In case performance deteriorates too much we'll have to think more about this.