Footnotes on 2019b addition of "Fri<=1" Rule about tzdb

[pavkam]

Hi Paul, Thanks for that.

You are correct, the code I put in is incorrect.
I would appreciate it if you submitted pull request and a test if you can.

Regarding the TZ in question - you are a better person than I am :) I cannot deal with "time nerds".

Thanks a mil - Alex.

[Pamoho]

Pulled - changed - testing completed and, aaargh!

Push is getting rejected. Tried a few options, but got nowhere. I'll try something else tomorrow morning (with fresh eyes).

Cheers, Paul!
Screenshot 2019-07-10 20 14 22

[pavkam]

I think you are trying to push into my repository directly. You do not have the rights to do it.

The procedure in GitHub is as follows:

1. Fork my repository into your account. (You can find the option once you view tzdb repo).
2. Clone your repo.
3. Add your changes and push to your repo.
4. Create a Pull Request for your repo back to my repo.
5. The owner of the main repo (me) will check the DIFF and apply or reject your PR, or comment. So if there's a bug or some non-conforming code you can fix it in your repo.

Once you do it once it becomes like second nature.

[Pamoho]

[Seriously, I need a holiday! Those beaches in Far North Queensland are calling!]

Your patient coaching paid dividends. See the "merge request" for TZdb.pas as per agreed actions.

Cheers, Paul

[pavkam]

Thanks Paul,

I will give it a look. In the mean time get a vacation (and don't get eaten by a koala! :)

Alex.

[pavkam]

Approved.

I will adjust the math from using subtraction to using IncDay/IncWeek function. That makes the code more readable as not everyone is aware of how date-time is represented.

Thanks a mil!

[Pamoho]

No worries - all good.

Consider this one closed :-)

Cheers, Paul