Crash on noicy signal about heartrate_analysis_python

[paulvangentcom]

Hi Yurasmol,

What sampling rate is the attached file recorded at? It's so noisy that I'm having issues seeing where the heart rate signal is.

Let me know and I'll see what I can do with some filtering. I'll also add error handling for this case.

Cheers,
Paul

[yurasmol]

Hi Paul! This is noisy signal from an empty sensor. I have a lot of signals in a flow. But I don't want the all module to crash because of an empty list valid_ma[] working_data['best'] = min(valid_ma, key=lambda t: t[0])[1] in function fit_peaks() in case of calculated bmp exceed bpmmax=180 In addition, this function does not inherit the parameter bpmmax from the wrapper function process() Sincerely yours, Yuri ----- Original Message ----- From: Paul van Gent To: paulvangentcom/heartrate_analysis_python Cc: yurasmol ; Author Sent: Sunday, January 20, 2019 5:10 PM Subject: Re: [paulvangentcom/heartrate_analysis_python] Crash on noicy signal (#5) Hi Yurasmol, What sampling rate is the attached file recorded at? It's so noisy that I'm having issues seeing where the heart rate signal is. Let me know and I'll see what I can do with some filtering. Cheers, Paul — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[paulvangentcom]

Hi Yurasmol,

Please pull the latest version. I've introduced custom exception handling to remedy your issue and make the error more verbose. These situations now trigger a UserWarning BadSignalWarning.

Note that you still need to catch any warnings and exceptions if you want execution to continue. Consider an example using 'data.csv' from the repo (sampled at 100Hz):

import heartpy as hp

if __name__ == '__main__':
    #Let's simulate empty valid_ma during iteration flow example 
    #by setting bpmmax to 40 (real is 58.92)
    bpmmax = [60, 40, 130] 
    data = hp.get_data('data.csv')
    for i in bpmmax:
        print(i)
        try:
            wd, measures = hp.process(data, 100.0, bpmmax=i)
        except hp.exceptions.BadSignalWarning as w:
            print(w) #display message
            pass #or just pass over it if you want

Note the above example steps over the UserWarning BadSignalWarning but will fail on any other exception. You'd need to catch that separately.

Lastly the non-inheritance of bpmmin and bpmmax has been fixed. Thanks for catching that!

I'll have a look at the other issue later in the week as I'm on holidays now so my time is limited.

Cheers,
Paul