Reusing GDataOAuthAuthentication with GDataOAuthSignIn fails due to stale token secret about gdata-objectivec-client

[GoogleCodeExporter]

I can't reproduce this. Nor do I understand it, since the token request isn't 
signed with the token or the token 
secret (the -tokenRequestKeys method lists what parameters the request request 
is signed with), and if the 
request succeeds, then the response (to requestFetcher:finishedWithData:) 
includes both a token and token 
secret, which immediately get saved together into the auth object.

Original comment by gregrobbins on 11 May 2010 at 2:04

[GoogleCodeExporter]

-tokenRequestKeys includes kOAuthSignatureKey, which causes 
-paramsForKeys:request: to call -signatureForParams:request:, which then 
creates a signature using 
the private key _and_ the currently stored token secret (line 281 of 
GDataOAuthAuthentication.m).  Here's the relevant backtrace.

#4  +[GDataOAuthAuthentication HMACSHA1HashForConsumerSecret:tokenSecret:body:] 
(self=0x5bd74, _cmd=0x4d9d6, consumerSecret=0x595c8, 
tokenSecret=0x0, body=0x727b2f0) at /Users/ddickison/src/iPhone 
Apps/Etsy/Libraries/gdata-objectivec-client/OAuth/GDataOAuthAuthentication.m:897
#5  0x0003e9dd in -[GDataOAuthAuthentication signatureForParams:request:] 
(self=0x7254120, _cmd=0x4dea1, params=0x727a2f0, request=0x727a250) at 
/Users/ddickison/src/iPhone 
Apps/Etsy/Libraries/gdata-objectivec-client/OAuth/GDataOAuthAuthentication.m:283
#6  0x0003e379 in -[GDataOAuthAuthentication paramsForKeys:request:] 
(self=0x7254120, _cmd=0x4debd, keys=0x727a2c0, request=0x727a250) at 
/Users/ddickison/src/iPhone 
Apps/Etsy/Libraries/gdata-objectivec-client/OAuth/GDataOAuthAuthentication.m:179
#7  0x0003f9ba in -[GDataOAuthAuthentication 
addAuthorizationHeaderToRequest:forKeys:] (self=0x7254120, _cmd=0x4dd05, 
request=0x727a250, 
keys=0x727a2c0) at /Users/ddickison/src/iPhone 
Apps/Etsy/Libraries/gdata-objectivec-client/OAuth/GDataOAuthAuthentication.m:558
#8  0x0003f3a9 in -[GDataOAuthAuthentication addRequestTokenHeaderToRequest:] 
(self=0x7254120, _cmd=0x4de23, request=0x727a250) at 
/Users/ddickison/src/iPhone 
Apps/Etsy/Libraries/gdata-objectivec-client/OAuth/GDataOAuthAuthentication.m:472
#9  0x0003c81f in -[GDataOAuthSignIn startSigningIn] (self=0x7270ce0, 
_cmd=0x4d30a) at /Users/ddickison/src/iPhone 
Apps/Etsy/Libraries/gdata-objectivec-
client/OAuth/GDataOAuthSignIn.m:167

Original comment by [email protected] on 11 May 2010 at 3:06

[GoogleCodeExporter]

Thank you for the elaboration, and for reporting the issue. I can reproduce the 
problem now.

Change submitted: 
http://code.google.com/p/gdata-objectivec-client/source/detail?r=527

Original comment by gregrobbins on 11 May 2010 at 7:57

• Changed state: Fixed