Coder Social home page Coder Social logo

Comments (3)

paulmillr avatar paulmillr commented on June 1, 2024

I believe the behavior in 1.7.0 is the correct one.

Why?

from noble-secp256k1.

paulmillr avatar paulmillr commented on June 1, 2024

I suggest to update your definition of tweak / publicAdd functions. They need to do the validation. P - P is valid point 0. It may not be valid in your context, but that's not applicable to everyone.

from noble-secp256k1.

landabaso avatar landabaso commented on June 1, 2024

I suggest to update your definition of tweak / publicAdd functions. They need to do the validation. P - P is valid point 0. It may not be valid in your context, but that's not applicable to everyone.

Thanks. I catch this case on my side now.

Why

Previous behavior up to version 1.7.0 did not return a point, which matched the behavior in tiny-secp256k1.
I simply assumed that this was the typical output for secp256k1 libraries and that this minor breaking change had not been intentional.

from noble-secp256k1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.