deno support about noble-ed25519

[paulmillr]

it should work, but it seems like we need to fix it

[pgg]

import * as ed from 'https://raw.githubusercontent.com/paulmillr/noble-ed25519/0.7.0/index.ts';

const PRIVATE_KEY = ed.utils.randomPrivateKey();
const HASH_MESSAGE = 'deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef';

const publicKey = await ed.getPublicKey(PRIVATE_KEY);
const signature = await ed.sign(HASH_MESSAGE, PRIVATE_KEY);
const isMessageSigned = await ed.verify(signature, HASH_MESSAGE, publicKey);

console.info(publicKey, signature, isMessageSigned);

[christianbundy]

I got Deno working with this library, but I couldn't figure out how to run the tests easily since they depend on Node.js for opening files and such. Maybe someone else can take it to the finish line?

https://github.com/christianbundy/noble-ed25519/tree/deno

(No guarantees that I haven't broken anything, use at your own risk.)

[christianbundy]

Thanks for the fix! I'm still seeing the old problems, could you help me figure out what I'm doing wrong?

$ deno --version
deno 1.0.0
v8 8.4.300
typescript 3.9.2
$ deno run https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/mod.ts
Compile https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/mod.ts
error: TS2531 [ERROR]: Object is possibly 'null'.
    const buffer = await window.crypto.subtle.digest('SHA-512', message.buffer);
                         ~~~~~~~~~~~~~~~~~~~~
    at https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/index.ts:514:26

TS2580 [ERROR]: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i @types/node`.
} else if (typeof process === 'object' && 'node' in process.versions) {
                  ~~~~~~~
    at https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/index.ts:520:19

TS2580 [ERROR]: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i @types/node`.
} else if (typeof process === 'object' && 'node' in process.versions) {
                                                    ~~~~~~~
    at https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/index.ts:520:53

TS2580 [ERROR]: Cannot find name 'require'. Do you need to install type definitions for node? Try `npm i @types/node`.
  const { createHash, randomBytes } = require('crypto');
                                      ~~~~~~~
    at https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/index.ts:521:39

Found 4 errors.

[paulmillr]

test ❯ cat a.ts 
import * as ed from 'https://deno.land/x/ed25519/mod.ts';
const PRIVATE_KEY = ed.utils.randomPrivateKey(); // 32-byte Uint8Array or string.
const HASH_MESSAGE = 'deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef';
const publicKey = await ed.getPublicKey(PRIVATE_KEY);
console.log(publicKey)
test ❯ deno run a.ts 
Uint8Array(32) [
  228,  5, 212, 192, 244,  83, 151, 120,
  238, 29,  77, 106, 177, 250, 129, 255,
  105, 61, 194,  34,  81, 101,  98,  11,
  180, 33, 220, 255, 179, 158,  17, 130
]

[christianbundy]

Maybe a silly question (sorry), but what's the difference between running from github.com vs deno.land?

$ deno run https://deno.land/x/ed25519/mod.ts
$ echo "no errors above"
no errors above
$ deno run https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/mod.ts
Compile https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/mod.ts
error: TS2531 [ERROR]: Object is possibly 'null'.
    const buffer = await window.crypto.subtle.digest('SHA-512', message.buffer);
                         ~~~~~~~~~~~~~~~~~~~~
    at https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/index.ts:514:26

TS2580 [ERROR]: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i @types/node`.
} else if (typeof process === 'object' && 'node' in process.versions) {
                  ~~~~~~~
    at https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/index.ts:520:19

TS2580 [ERROR]: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i @types/node`.
} else if (typeof process === 'object' && 'node' in process.versions) {
                                                    ~~~~~~~
    at https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/index.ts:520:53

TS2580 [ERROR]: Cannot find name 'require'. Do you need to install type definitions for node? Try `npm i @types/node`.
  const { createHash, randomBytes } = require('crypto');
                                      ~~~~~~~
    at https://raw.githubusercontent.com/paulmillr/noble-ed25519/master/index.ts:521:39

Found 4 errors.

[paulmillr]

yeah, you should use official modules @ deno.land

[paulmillr]

curl gives us:

content-type: application/typescript; charset=utf-8 for deno
Content-Type: text/plain; charset=utf-8 for gh

[christianbundy]

Looks like rm -rf ~/.cache/deno did the trick. I don't know what deno.land is doing to circumvent it, but I'll use permalinks when pulling from GH in the future. Thanks for your help!