Coder Social home page Coder Social logo

Comments (6)

paulmillr avatar paulmillr commented on May 28, 2024 1

yeah, probably. pull request with tests etc is welcome.

from ed25519-keygen.

paulmillr avatar paulmillr commented on May 28, 2024 1

@LuisOsta 0.4.1 is live now

from ed25519-keygen.

LuisOsta avatar LuisOsta commented on May 28, 2024

Here's the line that enforces the 32-byte limit -

message = ensureBytes(message, 32);

from ed25519-keygen.

LuisOsta avatar LuisOsta commented on May 28, 2024

@paulmillr I've created a PR #6 that removes the check, the tests pass. What tests would you want me to add if any? The change doesn't really deal with any of the cryptography but a semantic thing about size requirements

from ed25519-keygen.

LuisOsta avatar LuisOsta commented on May 28, 2024

Also @paulmillr I'm unsure if this is intentional but the top level npm test doesn't actually run the HDKey tests as those are defined & included under a separate package.json. So I don't think the automatic GitHub workflow actually runs the HDKey tests

from ed25519-keygen.

LuisOsta avatar LuisOsta commented on May 28, 2024

@paulmillr When do you think you'll be able to cut a new release?

from ed25519-keygen.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.