Coder Social home page Coder Social logo

Comments (3)

seanforyou23 avatar seanforyou23 commented on July 18, 2024 1

I thought adding a wiki entry might be a better place to start https://github.com/patternfly/patternfly-react-seed/wiki/How-to-remove-things-you-don't-need

I'll add info for jest, prettier, and eslint if everyone thinks it's generally an ok format

from patternfly-react-seed.

riccardo-forina avatar riccardo-forina commented on July 18, 2024

I can't say that I agree. Most projects require custom components and those are best developed in isolation in Storybook. Given that adding Storybook to the seed project wasn't a trivial operation, I think it does make sense to provide a ready-to-work-with solution for the average guy out there that doesn't want to mess with webpack & co.

Just my 2ยข ofc.

from patternfly-react-seed.

seanforyou23 avatar seanforyou23 commented on July 18, 2024

These are all valid viewpoints. This seed project, while serving nicely these days as a project starter, was born out of the need for an example of how to configure projects using patternfly/patternfly-react from a build perspective. Webpack was the common build tool that questions kept coming up about so we chose that as the base for the seed project to serve as example configuration. I think since the additional storybook related code and footprint are small, and yet solve an otherwise fairly intricate integration/config task (and elegantly) it makes sense to keep it.

It's a good point though, I imagine plenty of people may not necessarily need things like testing, bundle analyzers, and nested component demo apps. I'd be happy to add a section of doc that explains how to remove optional features like this for those who don't need/want them - probably a one-liner assuming you're not on windoze ๐Ÿ˜‰@ddonahue007 does that sound like an ok solution to you?

from patternfly-react-seed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.