Comments (3)
I thought adding a wiki entry might be a better place to start https://github.com/patternfly/patternfly-react-seed/wiki/How-to-remove-things-you-don't-need
I'll add info for jest, prettier, and eslint if everyone thinks it's generally an ok format
from patternfly-react-seed.
I can't say that I agree. Most projects require custom components and those are best developed in isolation in Storybook. Given that adding Storybook to the seed project wasn't a trivial operation, I think it does make sense to provide a ready-to-work-with solution for the average guy out there that doesn't want to mess with webpack & co.
Just my 2ยข ofc.
from patternfly-react-seed.
These are all valid viewpoints. This seed project, while serving nicely these days as a project starter, was born out of the need for an example of how to configure projects using patternfly/patternfly-react from a build perspective. Webpack was the common build tool that questions kept coming up about so we chose that as the base for the seed project to serve as example configuration. I think since the additional storybook related code and footprint are small, and yet solve an otherwise fairly intricate integration/config task (and elegantly) it makes sense to keep it.
It's a good point though, I imagine plenty of people may not necessarily need things like testing, bundle analyzers, and nested component demo apps. I'd be happy to add a section of doc that explains how to remove optional features like this for those who don't need/want them - probably a one-liner assuming you're not on windoze ๐@ddonahue007 does that sound like an ok solution to you?
from patternfly-react-seed.
Related Issues (20)
- Consider converting react-seed into a template
- Update to React 18 & PF 5
- add a11y testing script and ensure seed meets a11y standards
- react-seed: Consume v6 alphas and build Penta demo HOT 3
- error :( HOT 1
- bug - address vulnerabilities
- Pull in v6 alphas HOT 1
- Pull in v6 alphas HOT 2
- react-seed: Penta Page updates HOT 1
- react-seed: Penta Masthead updates
- Create a Penta demo app HOT 1
- React Seed demo screens for Penta HOT 1
- Dashboard page demo (Overview page)
- Primary details card view page (Resources page) HOT 1
- Filters demo in full page demo. (Inventory page) HOT 1
- Light/dark theme switcher HOT 2
- Update to official v6 alphas HOT 1
- outdated dependencies on main HOT 1
- Brand component: typo in brand name Patternfly HOT 1
- Update react seed v6 branch and demo to PF6 alpha omega versions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from patternfly-react-seed.