Coder Social home page Coder Social logo

Comments (3)

PatrickJS avatar PatrickJS commented on May 1, 2024

this is a browser thing where the type is probably a string so you would need to convert it via this._value = Number(newValue);. In TypeScript the types are removed when your code is compiled.

from mfe-starter.

dotcs avatar dotcs commented on May 1, 2024

Typescript is a typed superset of JavaScript that compiles to plain Javascript. In the example above Typescript assumes that newValue is a number. Whenever Typescript can check the type, it will do it for you. So Typescript would raise an error if you would try to do something like:

constructor() {
    this.onChange('abc');
}

onChange(newValue: number) {
    // ...
}

Unfortunately the component template is a string, which is only rendered at runtime. Because of this, Typescript does not now about your onChange call. Because Typescript compiles to plain Javascript, there is no way to do the type checking during runtime.

So yes, this is a problem. The only way to handle these kind of problems that I know is to do some additional type checking inside the function and be super careful about the arguments if Typescript can't do the proper checks for you.

To convert to a number you can always do

onChange(newValue: number) {
      console.log(+number * 3);
}

The unary plus operator enforces conversion to a number (see 4.14.2 The +, –, and ~ operators).

from mfe-starter.

PatrickJS avatar PatrickJS commented on May 1, 2024

@dotcs is correct in explaining how typescript works. if you need runtime type checks then you can check out this repo made by an angular core team member
https://github.com/vsavkin/RuntimeTypeChecks
If you have any more issues feel free to open another one or comment here

from mfe-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.