Coder Social home page Coder Social logo

Comments (7)

PatrickJS avatar PatrickJS commented on May 1, 2024

is this needed after you made your PR? if it's still needed can you make another PR?

from mfe-starter.

dotcs avatar dotcs commented on May 1, 2024

After #79 has been merged this issue should be fixed. For me npm run e2e runs without any problems now.

from mfe-starter.

PatrickJS avatar PatrickJS commented on May 1, 2024

awesome thanks!

from mfe-starter.

dotcs avatar dotcs commented on May 1, 2024

Sorry @gdi2290, I think you have to reopen this issue. I have had Chrome in my setup, not phantomjs. The latter indeed makes problems. Unfortunately I have no quick solution, so we have to start over.

from mfe-starter.

tamascsaba avatar tamascsaba commented on May 1, 2024

@dotcs what promles makes PhantomJS Unit tests run?

from mfe-starter.

dotcs avatar dotcs commented on May 1, 2024

Using the "recommended" config below, I could get the first E2E test to work (which checks the title of the page), but the following tests fail because it seems that PhantomJS does not wait for Angular before running the tests which is why they fail with an InvalidElementStateError [1].

capabilities: {
    'browserName': 'phantomjs',

    /*
     * Can be used to specify the phantomjs binary path.
     * This can generally be ommitted if you installed phantomjs globally.
     */
    'phantomjs.binary.path': require('phantomjs').path,

    /*
     * Command line args to pass to ghostdriver, phantomjs's browser driver.
     * See https://github.com/detro/ghostdriver#faq
     */
    'phantomjs.ghostdriver.cli.args': ['--loglevel=DEBUG']
  },

The linked document absolve also states:

Note: We recommend against using PhantomJS for tests with Protractor. There are many reported issues with PhantomJS crashing and behaving differently from real browsers.

So perhaps we should not use PhantomJS at all for E2E tests.

[1]: Some details on the InvalidElementStateError:

InvalidElementStateError: {"errorMessage":"SYNTAX_ERR: DOM Exception 12","request":{"headers":{"Accept-Encoding":"gzip,deflate","Connection":"Keep-Alive","Content-Length":"59","Content-Type":"application/json; charset=utf-8","Host":"localhost:20091","User-Agent":"Apache-HttpClient/4.4.1 (Java/1.8.0_66)"},"httpVersion":"1.1","method":"POST","post":"{\"using\":\"css selector\",\"value\":\"* /deep/ app /deep/ main\"}","url":"/elements","urlParsed":{"anchor":"","query":"","file":"elements","directory":"/","path":"/elements","relative":"/elements","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/elements","queryKey":{},"chunks":["elements"]},"urlOriginal":"/session/87a8c3c0-7896-11e5-8b2b-f10d392379d5/elements"}}
Build info: version: '2.47.1', revision: '411b314', time: '2015-07-30 03:03:16'

from mfe-starter.

PatrickJS avatar PatrickJS commented on May 1, 2024

If the issue is still valid please open a PR

from mfe-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.