build problem under windows about mfe-starter

[PatrickJS]

do you think you can you open a Pull-Request? :)

[beihaifeiwu]

I make it like this:

"env:dev": "SET NODE_ENV=development",
"env:prod": "SET NODE_ENV=production",

worked under winodws! output like:

λ npm run build

> [email protected] build C:\Users\Administrator\git\angular2-webpack-starter
> npm run build:dev && npm run build:prod


> [email protected] build:dev C:\Users\Administrator\git\angular2-webpack-starter
>  npm run env:dev  npm run webpack --colors --display-error-details --display-cached


> [email protected] env:dev C:\Users\Administrator\git\angular2-webpack-starter
> set NODE_ENV=development "npm" "run" "webpack"


> [email protected] build:prod C:\Users\Administrator\git\angular2-webpack-starter
> npm run env:prod npm run webpack --colors --display-error-details --display-cached


> [email protected] env:prod C:\Users\Administrator\git\angular2-webpack-starter
> set NODE_ENV=production "npm" "run" "webpack"

But I don't know if it work under linux and mac ?

[PatrickJS]

set won't work in linux and mac :/ I'm looking into ways to set the env that will work for both

[PatrickJS]

I removed prod/dev via c022ba9
I'm making a fullstack repo with server rendering so I'm going to keep this one client only

[RobHarrisAZ]

We had lots of problems getting this working under Windows. The problem ended up being npm running in a Windows Command Prompt. We installed Git for Windows (From Github) which also installs gitbash. Using the gitbash shell, executing the quick start and another window to also run the API server worked fine. Bottom line- don't waste your time trying to get this working from the Windows command prompt, it is expecting a bash-like shell.