"vb2: drop v4l2_format argument from queue_setup" commit breaks facetimehd about facetimehd

[patjak]

I'll soon create a mainline branch and start working on getting this upstream. Then I'll fix any breakage we currently have.

[patjak]

Been ignoring this for a while since I'm sure yet if I want to track upstream or keep it working for people who don't use the latest kernel. I don't want to litter the code if ifdefs. I think I'll finish the driver up and then prepare it for upstream as the last thing I do. Then development will stop here are we'll focus on the mainline kernel instead.

[xgnata]

Ok that's probably the best thing to do. Tons of ifdefs are a nogo.
We have until April 2016 before getting tons of complains for many
ubuntu users (16.04 will be shipped with linux 4.4)
Thanks for your work on the driver.

Xavier

Been ignoring this for a while since I'm sure yet if I want to track
upstream or keep it working for people who don't use the latest
kernel. I don't want to litter the code if ifdefs. I think I'll finish
the driver up and then prepare it for upstream as the last thing I do.
Then development will stop here are we'll focus on the mainline kernel
instead.

—
Reply to this email directly or view it on GitHub
#61 (comment).

[WhyNotHugo]

keep it working for people who don't use the latest kernel

Given that this targets desktop (as in "not servers"), I don't thinkg people will tend to use LTS stuff, or very slow-moving distros (eg: Red Hat?). 4.4 has been out for a while now (running 4.4.1 right now).

[psanford]

Having branches/tags that correspond with kernel releases would make it a lot easier for someone running an older kernel to be able to use the driver. So for example in a year from now when the kernel 4.9 is released and it changes all the v4l APIs, a user of Ubuntu 16.04 could at least easily find a version of the driver that would compile for their kernel.

Given that this targets desktop (as in "not servers"), I don't thinkg people will tend to use LTS stuff

I'm just a dataset of one, but I only use LTS releases on my desktops.

[WhyNotHugo]

keep it working for people who don't use the latest kernel

Right, but I'm sure you don't stagnate as much as those server sometimes seen running 4-6 year old kernels, that really what I meant.

[patjak]

Going to try to finish the driver up soon so we can mainline it. When that is done distros will have to use that version and these problems will go away. In the meantime I'll try to keep this stable on 4.2 to 4.4 kernels.

[chatziko]

For whoever's having the same issue, I managed to make it work under linux 4.5 using a small fix: chatziko@0e679c0.

Warning: I don't really know what I'm doing, I just read the message in the kernel commit and figured out what to change. Use at your own risk.

PS. thanks @patjak for the driver!

[xgnata]

I had only a quick look at
https://patchwork.linuxtv.org/patch/31986/
They do
alloc_ctxs[0] = dev_priv->alloc_ctx;
before

• if (*nplanes)

•   return sizes[0] < skel->format.sizeimage ? -EINVAL : 0;
  

  I haven't check if it matters but it is done like this in many other driver.
  However, there is also this /* FIXME: We assume single plane format here but not below */ which should be fixed first in order to have a clean code (looking at exemples in https://patchwork.linuxtv.org/patch/31986/ tells me that is should be an easy fix).

[egobrain]

any news?

[Agyapal]

Hello Guys,

I am also unable to update ixgbevf driver on latest ubuntu 16.04 community AMI - kernel 4.4.0-1012-aws

make install
make[1]: Entering directory '/usr/src/linux-headers-4.4.0-1012-aws'
Building modules, stage 2.
MODPOST 1 modules
make[1]: Leaving directory '/usr/src/linux-headers-4.4.0-1012-aws'
Copying manpages...
Installing modules...
make[1]: Entering directory '/usr/src/linux-headers-4.4.0-1012-aws'
INSTALL /root/ixgbevf-3.4.3/src/ixgbevf.ko
At main.c:222:

• SSL error:02001002:system library:fopen:No such file or directory: bss_file.c:175
• SSL error:2006D080:BIO routines:BIO_new_file:no such file: bss_file.c:178
  sign-file: certs/signing_key.pem: No such file or directory
  DEPMOD 4.4.0-1012-aws
  make[1]: Leaving directory '/usr/src/linux-headers-4.4.0-1012-aws'
  Running depmod...

uname -r
4.4.0-1012-aws

sudo modinfo ixgbevf 
filename:       /lib/modules/4.4.0-1012-aws/kernel/drivers/net/ethernet/intel/ixgbevf/ixgbevf.ko
version:        2.12.1-k
license:        GPL

Please suggest

[xgnata]

ixgbevf ?? Why do you post here?

[Agyapal]

As issue is same, so I posted here.. Unable to compile

Any hints

[xgnata]

It's just a warning telling you the module is not singed. It's not a problem. Your module is compiled.Try to load your module with modprobe. It should work. Le 13 avr. 2017 3:58 PM, "Agyapal" <[email protected]> a écrit :

…

As issue is same, so I posted here.. Unable to compile Any hints — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADAlhaOOLhc-sWBTAIPLxemc1kzIoQZnks5rvioDgaJpZM4HUp9n> .

[derjohn]

Don't forget to 'sudo depmod -a' before loading (or reboot ...). Otherwise modprobe will not find the shiny new fresh installed module.