Comments (2)
Hi Matt
I've changed #stop so it returns !running? - ie: an indication that Sphinx is not running, as you've suggested. Not sure when I'll get to the TS ticket for this too, but I was just on a roll with Riddle tonight :)
Cheers
from riddle.
Awesome, I was going to fork and submit a pull request if you gave the go ahead. That's really all I was waiting for, haha.
I don't mind doing the legwork on the TS ticket but there are several options and I wanted your feedback before I started. This fix is fairly integral, though.
Another thing is if Riddle::Controller#stop
is called and it finally has stopped, I think it raises Errno::ESRCH
(couldn't find process) error, so we might want to rescue for that error and return true in that case (as in, it's no longer running but was when last we tested if it was running).
from riddle.
Related Issues (20)
- Indexing on every save HOT 2
- Apostrophes not inserted HOT 2
- Zero results when search by association id HOT 4
- Ruby 3.0.3: File.exists? is deprecated; use File.exist? instead HOT 1
- test failure with ruby 3.0 HOT 5
- Tests are hanging on 32-bit architectures (e.g. i386, armhf) HOT 3
- Preserving original text on snippets HOT 2
- How to update and insert new data through Riddle HOT 1
- Combing OR and AND filters HOT 2
- Avoiding select star HOT 1
- sort-by attribute not found after updating to 1.5.10 HOT 18
- searchd and indexer sections as optional HOT 1
- Allow group_by multiple fields HOT 1
- Riddle::Query.escape misses some characters caught by Sphinx's EscapeString HOT 5
- Using Riddle to generate config files HOT 2
- Test files included in the gem file HOT 2
- plugin_dir should be located in common section HOT 7
- string and json attributes retrieved empty in matches HOT 7
- using group_concat in select causes exception HOT 2
- Index defining documentation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from riddle.