Issues with new NamedArgs mocks about pgxmock

[FryDay]

type AnyTime struct{}

// Match satisfies pgxmock.Argument interface
func (a AnyTime) Match(v interface{}) bool {
	_, ok := v.(time.Time)
	return ok
}

[FryDay]

If it helps, the sql seems to get rewritten by argsMatches here. This seems like where the issue is coming from, but I'm not sure what the best way to fix it would be.

[pashagolub]

What is the definition of postgresql.AnyTime{}?

[pashagolub]

OK, I found the issue. In short: pgxmock always expects WithRewrittenSQL() for QueryRewriter arguments. Which is way too strict, I must agree. This works for me:

func TestFail(t *testing.T) {
	t.Parallel()
	mock, err := NewConn(QueryMatcherOption(QueryMatcherEqual))
	a := assert.New(t)
	a.NoError(err)

	update := `
UPDATE "user"
SET email = @email,
    password = @password,
	pin = @pin,
	name = @name,
	software_admin = @software_admin,
	refresh_token = @refresh_token,
	updated_utc = @updated_utc
WHERE id = @id`

	mock.ExpectExec(update).WithRewrittenSQL(`
UPDATE "user"
SET email = $1,
    password = $2,
	pin = $3,
	name = $4,
	software_admin = $5,
	refresh_token = $6,
	updated_utc = $7
WHERE id = $8`).WithArgs(pgx.NamedArgs{
		"id":             "mockUser.ID",
		"email":          "mockUser.Email",
		"password":       "mockUser.Password",
		"pin":            "mockUser.Pin",
		"name":           "mockUser.Name",
		"software_admin": "mockUser.SoftwareAdmin",
		"refresh_token":  "mockUser.RefreshToken",
		"updated_utc":    AnyArg(),
	}).WillReturnError(errPanic)

	_, err = mock.Exec(context.Background(), update, pgx.NamedArgs{
		"id":             "mockUser.ID",
		"email":          "mockUser.Email",
		"password":       "mockUser.Password",
		"pin":            "mockUser.Pin",
		"name":           "mockUser.Name",
		"software_admin": "mockUser.SoftwareAdmin",
		"refresh_token":  "mockUser.RefreshToken",
		"updated_utc":    time.Now().UTC(),
	})
	a.Error(err)
	a.NoError(mock.ExpectationsWereMet())
}

As you can see I specified both queries to expect: initial and rewritten. Let me try to fix it. I think it's not that complicated

[FryDay]

I see, yeah, it almost feels backwards. If you manage to change it around, I'll be very happy!

[pashagolub]

Would you please try a fix in 167-fix-queryrewriter branch? This should work go get -u github.com/pashagolub/pgxmock/v3@167-fix-queryrewriter

[FryDay]

Yes, that works perfectly! I tested it with both my Execs and my Queries.