Coder Social home page Coder Social logo

Comments (5)

tomusdrw avatar tomusdrw commented on July 26, 2024

we already do that I believe.

from parity-bridges-common.

svyatonik avatar svyatonik commented on July 26, 2024

we already do that I believe.

I'm not sure - Wwe still have something like that all across the codebase:

[dependencies.frame-support]
version = "2.0.0-rc6"
tag = 'v2.0.0-rc6'
default-features = false
git = "https://github.com/paritytech/substrate/"

from parity-bridges-common.

tomusdrw avatar tomusdrw commented on July 26, 2024

I've tried that and it seems that some crates are not really released. It failed for me at substrate-test-runtime-client (CC @gnunicorn )
Afaict it means we can't really use crates.io versions anywhere else because of conflicts.

from parity-bridges-common.

svyatonik avatar svyatonik commented on July 26, 2024

We may just remove this dependency - it isn't super-important. I guess the other missing dependency will be node-primitives, but we should avoid using it. I'm introducing millau-primitives and rialto-primitives in #376 anyway.

But generally, imo, we should switch to crates.io anyway (sooner or later). If we're unable to reuse our own crates from crates.io, then noone can't :)

from parity-bridges-common.

gnunicorn avatar gnunicorn commented on July 26, 2024

It failed for me at substrate-test-runtime-client (CC @gnunicorn )

For which crates? I have a todo to fix the releasing process to publish everything that is not marked publish = false rather than matching specific names (as we do now). It seems that at least one or two matches were false and we didn't release a package or two - which I then added after. If you have any other misses, let me know.

I guess the other missing dependency will be node-primitives

Yeah, we are currently not releasing the binaries stuff, mainly because it changes soo often that it feels futile to even try to keep that semver compliant. That said, I have the plan to release at least the primitives and runtimes for both node and polkadot at some point, too.

Either way, even with that dependency missing, if you were to only pull that in via git (using the v2.0.0-tag) and everything else from crates.io should be working. Please let me know if not.

from parity-bridges-common.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.