Reuse subsystems in different orchestra about orchestra

[drahnr]

The issue with declaring tow #[orchestra::orchestra(..)] annotated types, with similar subsystems, yields two types of identical name, and a bunch of internal types with identical names than the original ones, but they don't have the same type id from a rustc perspective/are disjunct types. Hence why you run into the issue.

I only have ugly solutions for you. Happy to share if interested. (Hint: Modified import paths in all subsystems based on a feature-flag, I strongly recommend against that).

[drahnr]

The best approach might be to make the macro #[cfg(feature =.. )] aware and allow conditional compilation of fields of one orchestra declarated struct Foo.

[skunert]

The best approach might be to make the macro #[cfg(feature =.. )] aware and allow conditional compilation of fields of one orchestra declarated struct Foo.

So basically we would pass different feature flags depending on whether we compile for cumulus or polkadot and then disable some of the subsystems, but reuse the same orchestra? Did I understand that correctly?

One other solution (also hacky) I was thinking about was to introduce one more abstraction level below the macro level. And then reuse the same code but declare the subsystems separately in cumulus.

[drahnr]

The best approach might be to make the macro #[cfg(feature =.. )] aware and allow conditional compilation of fields of one orchestra declarated struct Foo.

So basically we would pass different feature flags depending on whether we compile for cumulus or polkadot and then disable some of the subsystems, but reuse the same orchestra? Did I understand that correctly?

Yes, that's correct.

One other solution (also hacky) I was thinking about was to introduce one more abstraction level below the macro level. And then reuse the same code but declare the subsystems separately in cumulus.

I am not sure I understand what you mean. Also note, that this is quite a bit of work and would add further complexity to the proc-macro, which is not desirable.

So far, the DummySubsystems seem to be the easiest path.

Chaninging the number of subsystems will percolate through quite some code in polkadot (i.e. the overseer down to service and cli due to the impl OverseerGen which takes args for all subsystems, it's specific to polkadot, still something to consider).

Let me think about this for a few days, I have a hunch where we could go with something like !/Infallible as a subsystem of which the orchestra proc-macro is aware.

Let's do a call on Friday~ish?

[skunert]

Thanks for the help! I think a call might be useful!