Coder Social home page Coder Social logo

Comments (4)

tomusdrw avatar tomusdrw commented on July 20, 2024

The discussed idea was to use associated types:

build_rpc_trait! {
 trait Rpc {
   fn some_method(&self) -> Result<String, Error>;
   fn some_other_method(&self) -> BoxFuture<String, Error>;
 }
}

struct RpcDefault;
impl Rpc for RpcDefault {
   fn some_method(&self) -> Result<String, Error> { unimplemented!() }
   fn some_other_method(&self) -> BoxFuture<String, Error>  { unimplemented!() }
}

struct RpcAsync;
impl Rpc For RpcAsync {
  type some_method = BoxFuture<String, Error>;

   fn some_method(&self) -> BoxFuture<String, Error> { unimplemented!() }
   fn some_other_method(&self) -> BoxFuture<String, Error>  { unimplemented!() }
}

from jsonrpc.

rphmeier avatar rphmeier commented on July 20, 2024

This is fine but the naming convention is pretty ugly (and rustc is bound to complain; users will need to use some custom lint settings).
We could require that the mandatory #[rpc] annotation be formatted like this:

#[rpc(name="rpc_nameHere", return=NameHere)]
fn name_here(&self) -> Result<Foo, Error>;

which will generate the associated type with name NameHere instead of name_here . This could be optional but this would introduce further parsing complexity in the macro implementation.

from jsonrpc.

tomusdrw avatar tomusdrw commented on July 20, 2024

Renamed the issue to support arbitrary return types with Into<BoxFuture<String, Error>> bounds.

We could then provide a special jsonrpc_core::Result type with proper From<Result> and Into<BoxFuture> implementation

from jsonrpc.

tomusdrw avatar tomusdrw commented on July 20, 2024

The core part of the code already have relaxed requirements and recent switch to proc-macro should allow for more free form types to be returned (for instance an enum encapsulating possible results that implements Into<BoxFuture>)

from jsonrpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.