Coder Social home page Coder Social logo

Comments (11)

jh-devv avatar jh-devv commented on June 16, 2024

@Conquerix I haven't looked into it, but you could look into it if mc-publish supports it

Does this require different like upload locations? Like different pages etc. on Modrinth?

from mc-modpack-kit.

Conquerix avatar Conquerix commented on June 16, 2024

Actually I upload my pack to curse forge only (mainly because of the mod ms present). On there when uploading a client pack version, you can include other files, and people usually put the server versions there.
I'll look a bit more into mc-publish

from mc-modpack-kit.

jh-devv avatar jh-devv commented on June 16, 2024

I'll look a bit more into mc-publish

Thanks!
At least different upload locations on modrinth/curseforge is planned! :3

from mc-modpack-kit.

Conquerix avatar Conquerix commented on June 16, 2024

Ok so I looked into it a bit more, it seems that one can use files-primary and files-secondary to specify which files go where when uploading several of them
In this discussion it seems to be the case, although I don't really know what globs are, I get the idea.
With this it seems there need to be a way to distinguish easily between the server and client packs.

Maybe it would be worth looking at a setup with one repo for one modpack project, with one directory for the client and one for the server, instead of having one project per folder in the same repo.

from mc-modpack-kit.

Conquerix avatar Conquerix commented on June 16, 2024

Ok nevermind with the primary and secondary files they seem to be deprecated (see here)
I wonder what would happen if the files input had several files in it. Would it need a lot of work to change ?

from mc-modpack-kit.

jh-devv avatar jh-devv commented on June 16, 2024

Would it need a lot of work to change ?

Hmm, idk if there is something like
type: client type of stuff?
But yea, currently its handling the uploads on its own (via GitHub Actions matrices) so it would be bit of an pain to change

from mc-modpack-kit.

Conquerix avatar Conquerix commented on June 16, 2024

The type: client thing seems to be in preparation for their v4 yup.
I'll try and see in my project how to do it without the matrices, seems doable and I have some free time :D

from mc-modpack-kit.

Conquerix avatar Conquerix commented on June 16, 2024

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works.
If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

from mc-modpack-kit.

jh-devv avatar jh-devv commented on June 16, 2024

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works. If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

The problem with this, does it work with other "monorepo" style of uploads?
Like could It build like 3 different types of the pack e.g. quilt, fabric and forge like currently :3 ?

from mc-modpack-kit.

Conquerix avatar Conquerix commented on June 16, 2024

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works. If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

The problem with this, does it work with other "monorepo" style of uploads?
Like could It build like 3 different types of the pack e.g. quilt, fabric and forge like currently :3 ?

What we could do is having a hybrid solution, for example, have each subdirectory of the git repo represent one pack, and in those there could be either the packwiz repo or 2 subdirectories client and server, each containing the corresponding packwiz repo of the same pack.
Btw,I've never seen a case where one pack has versions for different loaders without the versions being different projects, like Better MC

from mc-modpack-kit.

jh-devv avatar jh-devv commented on June 16, 2024

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works. If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

The problem with this, does it work with other "monorepo" style of uploads?
Like could It build like 3 different types of the pack e.g. quilt, fabric and forge like currently :3 ?

What we could do is having a hybrid solution, for example, have each subdirectory of the git repo represent one pack, and in those there could be either the packwiz repo or 2 subdirectories client and server, each containing the corresponding packwiz repo of the same pack.
Btw,I've never seen a case where one pack has versions for different loaders without the versions being different projects, like Better MC

Currently, they are the same version because of #49

from mc-modpack-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.