Comments (8)
This already looks the right amount of "simple" I shoot for ;) Let me get back to you tomorrow, I will give it some thought whether to do emits or a logger.
from node-openid-client.
Hello @JoshBarr, i think this would be a great addition, even better if you could contribute it.
my $.02 towards the API solution direction,
- do we need issuer / client instance specific loggers?
- do we need Issuer / Client specific loggers? > can't we do with one logger setting (similar to defaultHttpOptions set on Issuer) This would greatly reduce the efforts and keep the API simple and understandable.
- can the default logger state be disabled / not provided?
- is your problem error specific? Would you consider Issuer/Client being an EventEmitter?
from node-openid-client.
You're right, we probably don't need client-specific loggers. Something like this?
const Issuer = require('openid-client').Issuer;
Issuer.logger = console;
Making the Iss/Client into EventEmitters would actually be really neat – certainly would make logging easier, as we can just attach the logger to the events.
from node-openid-client.
@JoshBarr what do you think of a simple inclusion of debug instead?
from node-openid-client.
Debug would be fine for our use case - we only need to log some internals for troubleshooting purposes.
from node-openid-client.
Sounds good!
from node-openid-client.
Feel free to open PR, 'till then i will be closing non-Issues.
from node-openid-client.
hi @panva I needed to add in some logs into a fork of this repo so we could see why it was failing for us, i.e. which stage and for what reason and thought it could be useful for others.
It looks like this issue is closed for a while but I still think it useful.
There are a couple of other things I need to do such as update docs and add logging to other functions but wanted to see your initial thoughts before I invest too much 👍
from node-openid-client.
Related Issues (20)
- OAuth 2.0 Device Authorization Grant (Device Flow) - poll without PKCE HOT 3
- Type checking httpOptions and rejectUnauthorized
- RPError thrown when IdToken JWE Header enc is blank HOT 2
- client won't run under `edge` runtime HOT 1
- Support setting client_secret to an empty string when using client_secret_basic or client_secret_post HOT 1
- Cannot assign to read only property 'dpopProof' of object '#<Client>' HOT 2
- Unsuccessful Callback to Unknow client side error HOT 10
- isKeyObject check fails in Bun HOT 5
- Scope delimiter replace problem HOT 2
- Multiple authenticate requests from the same session causes state mismatch HOT 1
- Can't authenticate when the server advertises authorization_response_iss_parameter_supported HOT 2
- Requests made without Accept-Encoding header HOT 1
- "cty" should not be included in jwks query HOT 2
- URL is not a constructor at Issuer.request HOT 1
- Application and Identity manger on different domains HOT 1
- Support other status code than 200 HOT 4
- Unable to use private_key_jwt auth method with Azure.
- Audience matching doesn't work as intended HOT 1
- Using `authorizationUrl()` in combination with PAR adds too many parameters HOT 3
- update interface AuthenticateOptions to include redirect_uri HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-openid-client.