Coder Social home page Coder Social logo

Comments (9)

sidnarayanan avatar sidnarayanan commented on August 21, 2024

Private fix doesn't work perfectly since PF and SC matching doesn't seem to always work. Let's do it properly:

https://twiki.cern.ch/twiki/bin/view/CMSPublic/ReMiniAOD03Feb2017Notes#MET_Recipes

from pandatree.

sidnarayanan avatar sidnarayanan commented on August 21, 2024

One thing to note here: the PF candidates from the fix have to be fed back into puppi and fatjets

from pandatree.

yiiyama avatar yiiyama commented on August 21, 2024

If you are talking about applying the fix on PF candidates from the bad muon removal to MC, it is propagated everywhere.
https://github.com/PandaPhysics/PandaProd/blob/master/Producer/cfg/prod.py#L369-L372
These lines go into the analyzer and producer configs and replace packedPFCandidates with cleanMuonsPFCandidates.

from pandatree.

sidnarayanan avatar sidnarayanan commented on August 21, 2024

No, I was referring to propagating the EG correction back to PF level. Related: right now we set electron pfPt by looking for a PF cand that is an electron, but sometimes it's a photon at pf level (and vice versa). Could we make it an OR of the PF IDs?

from pandatree.

yiiyama avatar yiiyama commented on August 21, 2024

Yes, that came up with Brandon too. One of my PRs do that - I forgot which..

from pandatree.

yiiyama avatar yiiyama commented on August 21, 2024

But I thought we don't apply EG correction to PF candidates? CMSSW recipe is to correct just the MET, no?

from pandatree.

yiiyama avatar yiiyama commented on August 21, 2024

PandaPhysics/PandaProd#6

This does not include fix on PF candidates though, if we want to do that.

from pandatree.

sidnarayanan avatar sidnarayanan commented on August 21, 2024

Sorry, that was my mistake. We indeed don't want to propagate things to PF candidate level. PandaPhysics/PandaProd#6 looks good to me

from pandatree.

yiiyama avatar yiiyama commented on August 21, 2024

Sid is seeing discrepancies between nero and panda.

from pandatree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.