panavtec / clean-contacts Goto Github PK

When I use a fragment subclass of a BaseFragment that implements a Thread decorated view, the ViewInjector.inject method doesn't inject the view, it remains null after the injection. The ViewInjector.inject method is taking the right class (the fragment subclass).

There are a couple of broken classes/tests (PresenterTest and TestInteractorInvoker, if I'm not wrong).

Could you please update slides link for v2 (english one http://es.slideshare.net/ChristianPanadero/my-way-to-clean-android-v2-english-droidcon-spain)
Don't know if there is update for spanish, and video
Thanks!

This may speed up compile times, use this plugin:

https://github.com/tbroyer/gradle-apt-plugin

As suggested by hvisser in https://bitbucket.org/hvisser/android-apt/issues/18/support-java-plugin

Hi, I had no idea where to leave my feedback so I've created an issue. Hope it's ok.

Great work with the project. I was thinking about your solution with retaining presenters using handler hack. It's pretty clever but I have my doubts about leaking activity and that it simply doesn't work. Notice that your module (MainModule) is holding reference to MainView that is implemented by Activity. When you are retaining instance of object graph for screen rotation you are leaking activity because new Activity is created but the old one is still hold by object graph. What is worse is that presenter that should work on new instance of Activity(MainView) has the reference to the old one.

Am I missing something here? Please correct me if I am wrong.

http://panavtec.me/modeling-my-android-domain-layer/

http://panavtec.me/another-approach-to-handle-domain-errors/

When you call the method "Contact obtain(String md5)", you return null if the cache is invalid. This will throw an exception if you wait a while to navigate the MainActivity to DetailActivity, since there would be no data to display in the DetailActivity. I apologize for my basic level of English, I just speak Spanish.

Hi there!

Great repo. Thank you :)

However, I just cloned the latest master branch and it looks like there are still some unresolved merge conflicts in the code.

For example: ActivityModule.java

<<<<<<< HEAD
import me.panavtec.cleancontacts.ui.errors.ErrorManager;
import me.panavtec.cleancontacts.ui.errors.SnackbarErrorManagerImp;
=======
import android.view.Window;
>>>>>>> release/0.8

Hi.

I was wondering if the following behaviour is expected when rotating the screen, or if that will be fixed in a later release:

1. When first scrolling down the list of contacts and then rotating the screen, the position in the list goes back to the first contact instead of resuming at the scrolled-to position.
2. In the "Detail" view, the resolution of the photo appears to be updated once available. When rotating the screen, the photo goes back to low resolution and appears to be never updated again.
   I've just tried running the app and did not yet look into the details of the code regarding the rotation part.
   Anyway, thanks for a great project!

Give a warning by console if InteractorOutputInjector.inject(_) does nothing because the parameter is not a valid one (annotated with Outputs annotation)

The Presenter.getView() can be null. Consider the case that the interactor result returns after call detachView. The view is null and the presenter is crashing, to solve it, return a NullObjectPattern of the View in the Presenter BaseClass to avoid undesired crashes.

If you want to save the results for later present, you need to handle this by your self in the presenter

Why not used you the transformer library in the presentation layer?