event codes not in pyinotify.EventsCodes about werkzeug

[mitsuhiko]

Who the hell moves constants around without updating the docs? Can someone confirm this change?

[romme]

Apparently it is in the documentation: http://seb-m.github.com/pyinotify/

But this change looks quire unreasonable anyway.

[mitsuhiko]

They are still on the event codes object anyways, so they are not moved but copied according to the docs.

[luizvital]

Well, apparently the pyinotify API docs weren't updated clearly, but since 0.8 version the flags aren't present as attributes of the EventsCodes class anymore, they are in the pyinotify module directly or in EventsCodes.ALL_FLAGS dictionary as per the source code https://github.com/seb-m/pyinotify/blob/master/python2/pyinotify.py#L510.

The pyinotify 0.7 source are still in sourceforge, just in case you'd like to compare http://sourceforge.net/projects/pyinotify/files/pyinotify/0.7.1/pyinotify-0.7.1.tar.bz2/download

I've bumped into this problem when evaluating MapProxy (https://bitbucket.org/olt/mapproxy/src/ba32ad0a0ffc/mapproxy/util/ext/serving.py), I've opened an issue there with a patch https://bitbucket.org/olt/mapproxy/issue/24/pyinotify-api-error-in-servingpy-werkzeug

[olt]

But the flags are set to EventsCode in line 513.
https://github.com/seb-m/pyinotify/blob/master/python2/pyinotify.py#L513

Guess it wasn't there in one of the 0.8 versions. What exact version are you using?

[luizvital]

I'm using 0.8.9.

But the line you pointed set as attributes the keys of EventsCodes.FLAG_COLLECTIONS dictionary, they are OP_FLAGS, EVENT_FLAGS, SPECIAL_FLAGS. So for ex, EventsCodes.IN_DELETE_SELF doesn't exist anymore, instead you have to access as EventsCodes.OP_FLAGS['IN_DELETE_SELF'] or EventsCodes.ALL_FLAGS['IN_DELETE_SELF']

[olt]

Ah, you're right. I didn't noticed that FLAG_COLLECTIONS was nested.