Coder Social home page Coder Social logo

Comments (6)

untitaker avatar untitaker commented on May 4, 2024 2

We should set a manual description for this function, and refer to Werkzeug docs (see intersphinx for that).

Another reason for a necessary rephrasing is that "return a WSGI application" is unnecessarily low-level for Flask's docs, and only appropriate for Werkzeug's.

from pallets-sphinx-themes.

davidism avatar davidism commented on May 4, 2024

@untitaker really not sure what to do here. Maybe there's a way to indicate the package as well as the version for externals we're re-documenting? Or disable the versions in those cases? This came up while looking at pallets/flask#1704.

from pallets-sphinx-themes.

davidism avatar davidism commented on May 4, 2024

Similar to how I wrote a plugin to collapse old version directives, maybe we can write a plugin that adds "Werkzeug version ...". That would be a lot more maintainable.

from pallets-sphinx-themes.

tristanfisher avatar tristanfisher commented on May 4, 2024

I apologize if this is more general, but what level of technical detail is desired when writing Flask docs? I wouldn't consider mentioning WSGI to be low-level, but can understand if that's meant to be abstracted.

from pallets-sphinx-themes.

davidism avatar davidism commented on May 4, 2024

I don't have a particular problem with how the API docs read currently. If we need to simplify something that can be done at a later time.

from pallets-sphinx-themes.

davidism avatar davidism commented on May 4, 2024

I've started investigating this. It's going to be messy, but I think it's possible.

The sphinx.domains.changeset.VersionChange directive class controls the version messages. Unfortunately, it's not designed to be overridden, the sphinx.domains.changeset.versionlabels dict has strings that expect one %s substitution only, such as 'Changed in version %s'. This substitution is done a few lines in to the VersionChange.run method. We'll have to copy and modify the code for that method.

Once we do that, we can look up VersionChange.source in intersphinx. If it's not there, we can fall back to the source package name instead of the intersphinx title. If there's no intersphinx method for looking it up, we can fall back to scanning VersionChange.env.intersphinx_inventory.

Still need to investigate how we could determine if the source is the current package being documented, or an inherited method. That way we could exclude the package name if it's the current package. I think I'd actually prefer everything to have package names consistently though.

from pallets-sphinx-themes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.