RSpec matchers doesn't work about active_delivery

[palkan]

Any advices with how to fix that?

The easiest way to fix Spring is to get rid off it))

[brovikov]

@palkan probably we could in doc explicitly tell to use require "active_delivery/testing/rspec" because now it shows require "active_delivery/testing" and it doesn't make a trick for me, when spring is using.

[iBublik]

Oh, I found that the actual reason is Spring. Any advices with how to fix that?

[iBublik]

I understand, but it's not an option for now :)

[palkan]

the actual reason is Spring

Could you tell more about this? Spring shouldn't break anything after restart

[iBublik]

After some debugging I found that this check fails https://github.com/palkan/active_delivery/blob/master/lib/active_delivery/testing.rb#L48 and file is not required. Don't know why running via Spring makes RSpec constant to be not defined at this moment.
For now I just added require 'active_delivery/testing/rspec' in my rails_helper.rb and everything works fine. I can make a PR with addition to documentation about this case if it's ok to you

[palkan]

Don't know why running via Spring makes RSpec constant to be not defined at this moment.

Got it.

Do you have spring-commands-rspec?_)

We had a similar problem in test-prof: test-prof/test-prof#8

Solution would be to change the check to defined?(RSpec::Core). Could you check it and propose a PR if it works?

[iBublik]

Do you have spring-commands-rspec?_)

Bingo :)

Solution would be to change the check to defined?(RSpec::Core). Could you check it and propose a PR if it works?

Unfortunately it didn't help

[palkan]

Hm, what about adding require "active_delivery/testing/rspec" to rails_helper.rb explicitly?

[iBublik]

Hm, what about adding require "active_delivery/testing/rspec" to rails_helper.rb explicitly?

Already done that, see my comment #12 (comment)

[palkan]

Sorry, missed this.

I can make a PR with addition to documentation about this case if it's ok to you

That would be great)

[palkan]

Done. Thanks!