Indentation control error about tslint

[ashwinr]

yeah, we've ourselves hit a few "nicely formatted" code causing errors. Do you actually find this rule useful in other cases? Wondering if we should just remove it altogether or not.

[osimicek]

Thanks for fast response.
I think the indent control of function call parameters should be set off. It shouldn´t control format of inner arrays, dictionaries or funtion definitions.

I tried following construction and that works fine. The problem is only in function calls in the first post.

arr = [ "item1",
        "item2",
        "item3",
        (data) => {
            console.log(data);
        },
        {
            "key1": 1,
            "key2": 2
        }
    ];

dict = {"key1"  : 1,
        "key2"  : 2,
        "key3"  : 3,
        "funct" : (data) => {
                        console.log(data);
                    },
        "arr"   : [
                    "key1",
                    "key2"
                    ]
    };

[ashwinr]

fair enough, I can remove that. A case we hit in particular was when objects were nested within arrays like so (note the positioning of the opening brace on line 6). I'm going to account for that use-case as well.

var x = [
    {
        a: 1,
        b: 2,
        c: 3
    }, {
        b: 4,
        a: 2
    }
];

[osimicek]

Sorry but I´m confused by your last post.
I only need in my code write function calls as follows:

registerController('baseCtrl',
                    BaseCtrl,
                    [
                        "$scope",
                        "$compile",
                        "$http",
                        "$routeParams"
                    ]);

[ashwinr]

Yeah, I know. The problem I think is that this rule is too restrictive sometimes, even with other code like the one I showed before. I'm going to take a look later, and see if we need to check for indentation at all for arrays and objects. It's probably easier to remove those checks altogether.