Split whitespace rule about tslint

[Bartvds]

I also get an error similar to this that can't be toggled with the whitespace rule:

if (condition){

}

Note the lack of space after the conditional, it triggers 'missing whitespace'.

[ashwinr]

this is handled by the "oneline" rule, and should be optional. I'm making it so, now. thanks!

[ashwinr]

I think it's useful to have optional arguments to rules. So in this case, the "oneline" rule would have an optional rule argument to also check for preceding whitespace. I am going to slightly break the configuration file format for such rules to allow for additional rule options like eslint.

So rules like "indent" would now have to be written as indent: [true, 4].

[Bartvds]

I've been following ESLint for some time and I agree, it allows for more detailed configuration.

Maybe also nest the rules in a "rules" element for future-proofing.

I also like how they split problems in multiple levels, like warning and errors.

[ashwinr]

sure. ESLint's rule names also are clearer in some cases, so I'm going to reconsider a few rule names of our own (I named them for consistency with JSHint, but that might not be a big concern).

[Bartvds]

Personally I have great hopes for ESLint, it feels like it is the next-gen linter, based on the experience from using JSHint.

I also like their idea of pluggable rules, it lets many contributors add all kinds of rules; it really benefits the project.

[ashwinr]

rules now have optional arguments. the oneline rule with whitespace checks is now written as: oneline: [true, "check-whitespace"]. Also, 0.2 of tslint and grunt-tslint are out and incompatible with rule files from 0.1.

[Bartvds]

I see the 0.2 update, checks out.

But doesn't that leave the splitting of this rule open? As some of the cases it covers are not really same thing (like we discussed above).

[ashwinr]

Sure, we can make each individual check an option of the "whitespace" rule.

[ashwinr]

fixed by 129e917