DockerExtension should allow string-based dependsOn about gradle-docker

[uschi2000]

Do you have a minimal example that clarifies the inconsistency?

On Wed, Apr 20, 2016 at 2:29 PM Michael Nazario [email protected]
wrote:

I was quite confused to have to use real task objects rather than strings
in the dependsOn field in the docker block. We should be able to use
string-based input too just like a normal gradle task.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#40

[mnazbro]

task bar() {
}
task foo() {
    dependsOn bar
}

and

task foo() {
    dependsOn 'bar'
}
task bar() {
}

vs

task foo() {
}
docker {
    name 'hub.docker.com/username/my-app:version'
    dependsOn foo
}

and

task foo() {
}
docker {
    name 'hub.docker.com/username/my-app:version'
    dependsOn 'foo'
}

[mnazbro]

It's important to note that the string version allows you to have not defined the task yet (and use a path to a task in a different project)

[uschi2000]

Hmm, it's odd that the docker plugin configures dependencies via the
DockerExtension. A more natural implementation would use task dependencies
instead.

On Wed, Apr 20, 2016 at 3:09 PM Michael Nazario [email protected]
wrote:

It's important to note that the string version allows you to have not
defined the task yet (and use a path to a task in a different project)

—
You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#40 (comment)

[mnazbro]

The DockerExtension also does something extra though. It copies the output of each of those dependsOn tasks into the docker build folder.

[uschi2000]

Yep, I know. But really the task should do that.

On Wed, Apr 20, 2016 at 5:12 PM Michael Nazario [email protected]
wrote:

The DockerExtension also does something extra though. It copies the output
of each of those dependsOn tasks into the docker build folder.

—
You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#40 (comment)

[rmelick]

I agree. Why is the docker task created by this plugin different from a normal gradle task, which would allow me to use the normal dependsOn?

I did figure out a workaround to allow referencing tasks by string, but it seems like there should be a better way to fix this. You can use the tasks.getByPath method (see https://docs.gradle.org/current/userguide/more_about_tasks.html)

dependsOn tasks.getByPath('bar')

Any guidance on where the docker task is defined in the code? I'm happy to send a pull request (although this would be the first gradle plugin I've worked on).

[markelliot]

We need/want to actually capture the task outputs when using dependsOn in the configuration. You can always grab the task and encode a dependency using something like tasks.docker to get a handle on it and add your dependencies.