Blank numeric cells are zero rather than null about poiji

[ozlerhakan]

Hi @alexandrarprice ,

Have you tried to initialize the field to null or other values like:

@ExcelCell(0)
private Integer total = -1;

@ExcelCell(1)
private Float total = null;

You can use wrapper classes of primitive types with poiji.

[alexandrarprice]

Hey, thanks so much for the quick response!
We just tried this and we found it was still being overwritten as zero. If this isn't the intended behavior, we'd be happy to try our best shot at a PR!
Thanks!

In case it helps at all, here's a sample of what our object looks like:

 @ExcelCellName("Cost")
  private Double cost = null;

We tried it with @ExcelCell as well, same results.
Tagging teammate @mindyor as I'll be headed out on vacation this afternoon. Thanks!

[ozlerhakan]

Hmm, I can also investigate if you have a test excel file @alexandrarprice

[mindyor]

Thanks for helping us take a look!

Uploading a zip (Archive.zip) with two toy files:

1. sample.xlsx works, does initialize Cost automatically to null or to a number should we choose to.

// sets blank cost to null
@ExcelCellName("Cost")
private Double cost;

// sets blank cost to 12
@ExcelCellName("Cost")
private Double cost = 12d;

2. sample.xls shows us 0 regardless of what we initialize cost to.

[mindyor]

Using PoijiOptions.preferNullOverDefault didn't seem to help :/

[ozlerhakan]

Hi @mindyor and @alexandrarprice ,

Could you try the 1.16 snapshot for this case:

<dependency>
  <groupId>com.github.ozlerhakan</groupId>
  <artifactId>poiji</artifactId>
  <version>1.16-SNAPSHOT</version>
</dependency>

You need to use PoijiOptions.preferNullOverDefault to set Float, Double, Integer, Long (i.e. wrapper classes of primitive types) , java.util.Date and String values to null.

[mindyor]

Hm, I seem unable to pull down that snapshot.

https://jcenter.bintray.com/com/github/ozlerhakan/poiji/ and https://repo.maven.apache.org/maven2/com/github/ozlerhakan/poiji/ only go up to 1.15.

[ozlerhakan]

You can see the snapshot over there: https://oss.sonatype.org/content/repositories/snapshots/com/github/ozlerhakan/poiji/

You should mention this url in your pom file as a reporsitory. You can look at this gist for details: https://gist.github.com/ktuukkan/8cf2de1e915185118c60

[mindyor]

Ah, got it. Thank you.

Without preferNullOverDefault(true), the same behavior persists (defaults to 0) for XLS
With preferNullOverDefault(true), String cells are null for both XLS and XLSX.

[ozlerhakan]

So this is what you want? @mindyor

[mindyor]

Sorry for not being clearer.
No, it looks like this change breaks the existing functionality for String.

[ozlerhakan]

But if we use preferNullOverDefault(true) String values should be null. Otherwise, String fields will be assigned to an empty String. What do you think?

[mindyor]

I agree, but even cells that are non-empty are being parsed in as null. Are you able to replicate this?

[ozlerhakan]

hmm, interesting, do you have a mockup excel ?

[mindyor]

The excel in the zipfile attached above (sample.xls in Archive.zip) should work.

[ozlerhakan]

You can try again the same snapshot, I think I have fixed that problem.

[mindyor]

Yes!! Looks good 👍 !!

[ozlerhakan]

1.16 is now available @mindyor @alexandrarprice

[alexandrarprice]

Awesome, thank you so much!!