Coder Social home page Coder Social logo

Comments (44)

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024 1

Well, now the original problem that the square cover art widget didn't load CAME BACK.
IT WORKED WHEN THE QUALITY WAS BAD I.e. previous canary.

from auxio.

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024 1

@OxygenCobalt The latest canary app works perfectly for me.
Widget load perfectly.
Thank you.
Here's the latest bug report anyway.
https://mega.nz/file/wvJShBgC#8YWJJ_lfgE-4km0vQnViilpXnDtEMWsNkrii3GhbLag

from auxio.

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024

Bug report
https://mega.nz/file/lzh0gYpJ#GL-TPgT-SnkXTvUWwaUANBiui_9SYRNJViAe5S_PiwI

from auxio.

shashankmunda avatar shashankmunda commented on August 15, 2024

@Mischievous-Loner seems like you're using a custom launcher, have you checked if it's a problem with the launcher?

from auxio.

Book-reader avatar Book-reader commented on August 15, 2024

I can reproduce this on an oppo A54s on ColorOS 13 with the default launcher & Auxio 3.5.2.
The widget does load with a square album cover when Auxio is floating but not otherwise.

Widget with rectangular album cover
Record_2024-07-16-08-53-07.mp4
Widget with square album cover
Record_2024-07-16-08-53-47.mp4
Widget with square album cover while Auxio is floating
Record_2024-07-16-08-55-38.mp4

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Thanks for reporting this @Mischievous-Loner @Book-reader, will take a look

from auxio.

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024

It's same with default device launcher

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Auxio_Canary.zip

Can you please take a bug report from the APK in this file @Mischievous-Loner @Book-reader

from auxio.

Book-reader avatar Book-reader commented on August 15, 2024

bugreport-CPH2273-TP1A.220905.001-2024-07-21-09-43-23.zip

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Identified it @Book-reader, android can't handle widgets with bitmaps that are too big, and it seems like your device is erroring out when that happens. It only happens with non-1:1 covers I imagine because of the extra pixels added by them. I need to reduce the size limit. For now reduce the size of the covers in your music files and/or switch Settings -> Content -> Album covers back to fast.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Care to try the APK in this ZIP file @Book-reader @Mischievous-Loner?

Auxio_Canary.zip

from auxio.

Book-reader avatar Book-reader commented on August 15, 2024

It still behaves the same (with fast album covers as well)

Record_2024-07-21-15-32-32.mp4

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Sorry, messed up the fix, try this @Book-reader @Mischievous-Loner

Auxio_Canary.zip

from auxio.

Book-reader avatar Book-reader commented on August 15, 2024

It is still the same
I also tested with the album cover as a 16k 16:9 png & a 16x16px png and the 16:9 image only worked in the debug build but the 1:1 failed on both the latest release & the debug
album covers are fast

16x16px album cover (same results on latest release & debug)
Record_2024-07-21-17-16-15.mp4
16:9 16k album cover (debug build)

Screenshot_2024-07-21-17-13-01-50_b783bf344239542886fee7b48fa4b892

16:9 16k album cover (latest release)
Record_2024-07-21-17-27-07.mp4

from auxio.

Book-reader avatar Book-reader commented on August 15, 2024

I also noticed that the album covers do not get refreshed in either build when pressing the rescan music button, the file has to be renamed

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Alright @Book-reader, my assumption is that this isn't a simple device-specific variation but instead your phone having the Android 12/13 bug where Android thinks the widget's album cover takes up far more space than it actually does. It only appeared in the newer versions since I added new widget layouts (which apparently makes Android think the bitmap is even bigger).

I can only mitigate this by drastically reducing album cover resolution, which will make it really blurry. I could also discard widget layouts until it all fits, at the cost of breaking the widget in some cases. I doubt either is desirable, but there's not much else that can be done. You could also look into trying to update your phone to newer versions without the bug, as it was fixed by google at some point.

from auxio.

sakuranonamida avatar sakuranonamida commented on August 15, 2024

Same happened with my phone (stock launcher, vivo y31, funtouch os 13(android 13))

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Can you try this @Book-reader @Mischievous-Loner @shashankmunda? I made the album cover size patch much more drastic:

Auxio_Canary.zip

from auxio.

Book-reader avatar Book-reader commented on August 15, 2024

The album cover does appear, but as you said is very blurry

Screenshot_2024-07-25-16-13-17-05_b783bf344239542886fee7b48fa4b892

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

The album cover does appear, but as you said is very blurry

Screenshot_2024-07-25-16-13-17-05_b783bf344239542886fee7b48fa4b892

As I thought. This is indication that your phones ROM has not patched the bitmap size bug. There is nothing I can do

I can only assume at this point to basically just disable the covers on smaller widget forms as needed and make it progressively less usable.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Try this @Book-reader @Mischievous-Loner @sakuranonamida?

Auxio_Canary.zip

from auxio.

sakuranonamida avatar sakuranonamida commented on August 15, 2024

Screenshot_2024_0730_103043.jpg

Try this @Book-reader @Mischievous-Loner @sakuranonamida?

Auxio_Canary.zip

Still the same and it doesn't work:(

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Confusing, can you reproduce the bug and then take a bug report afterwards @sakuranonamida?

from auxio.

sakuranonamida avatar sakuranonamida commented on August 15, 2024

Confusing, can you reproduce the bug and then take a bug report afterwards @sakuranonamida?

bugreport-CPH2273-TP1A.220905.001-2024-07-21-09-43-23.zip

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

I might have uploaded the wrong build, trying again @shashankmunda @Mischievous-Loner @Book-reader

Auxio_Canary.zip

If it still doesn't work, reproduce and then immediately take a bug report again.

from auxio.

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024

Sorry for not replying, was really busy with work.
The above Auxio_Canary works perfectly for me.
Thank you very much.
πŸ‘πŸΌπŸ«‘

from auxio.

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024

But widget album art image quality is poor in canary.
I have enabled high quality album art in both the apps.

Screenshot_20240803-075834
Thoe this problem is not a priority for me.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Whoops, I forgot about the downsizing I did in prior attempts to patch this.

Try this @shashankmunda @Mischievous-Loner @Book-reader?

Auxio_Canary.zip

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Well, now the original problem that the square cover art widget didn't load CAME BACK.
IT WORKED WHEN THE QUALITY WAS BAD I.e. previous canary.

Weird, can you please reproduce the issue on the latest APK and then immediately take a bug report so I can get more info @Mischievous-Loner?

from auxio.

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024

https://mega.nz/file/JvA2WRBY#ZMPRkrX80bsi-TOQeNuwXPTslyv8vSWR1g7DZ3RitHY

from auxio.

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024

rectangular cover loads while square one doesn't.
It worked in your previous debug but image was crap.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Okay @Mischievous-Lone @sakuranonamida @Book-reader, try this out. I'm 90% sure this wont work, so please reproduce the error if it exists and send a new bug report. I need the logs to figure out why my mitigation is failing.

Auxio_Canary.zip

from auxio.

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024

As you said this doesn't work.
Here's the bug report-
https://mega.nz/file/FmZB3TgL#zd2Bl7d7vWJ9AZ1GYwnBVolQkYElPBZi789Jg3ap78Y

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

So that was apparently never the bug I was looking for @Mischievous-Loner.

I think it's actually simple: I scale down the image to fit under the limit assuming a square image (since the widgets were written before allowing non-square covers). This is now inadequate since non-square covers can still exceed the size limit.

I have to find a way to first see the dimensions of the cover and then dynamically change how it's resized to ensure that it fits under the limit reasonably. This is going to be frustrating and requires some dependency work, so hold tight @sakuranonamida @Book-reader @Mischievous-Loner

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Try this @Mischievous-Loner @Book-reader @sakuranonamida, again no guarantees

Auxio_Canary.zip

from auxio.

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024

Now Widget doesn't load regardless of the dimensions of the cover image.
Previously at least the rectangular ones worked.
There was no such bug till version 3.3.3

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Okay, at this point I am going crazy and just increasing the reduction alongside adding some new debug info to this build @sakuranonamida @Book-reader @Mischievous-Loner

Auxio_Canary.zip

Your build displays the maximum bitmap memory I should see from your device up at the top above the songs/albums/artists/genres/playlists tabs. I know the one it actually is: 6912000. If it differs, that means your OEM modified that code and that's why the widget fails. This is where the second part comes in, the text below the maximum memory is your make and model. If your image size differs, I am giving up and hard-coding in your device into the app with that bitmap limit and using that cap, since I cannot be bothered with how Huawei or Oppo or whatever decided to randomly mangle third party widgets.

from auxio.

Book-reader avatar Book-reader commented on August 15, 2024

Screenshot_2024-08-09-13-51-58-19_65b8df5a000978b3161002a299fb7747

the widgets do work in this version (but are blurry)

Screenshot_2024-08-09-14-00-30-02_b783bf344239542886fee7b48fa4b892

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Can you try the build from #828 (comment), reproduce the broken widget, and then take a bug report @Book-reader?

from auxio.

Book-reader avatar Book-reader commented on August 15, 2024

Here:
bugreport-CPH2273-TP1A.220905.001-2024-08-09-15-28-15.zip

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

So it does differ on your device @Book-reader: 6912000 instead of 6670080. Regardless, I'm still scaling too much. I just have to fiddle with the reduction in size until I hit the maximum size I can go for that is still at least slightly high quality.

Try this out @Book-reader @Mischievous-Loner, it might be higher quality (or it might just crash again...)
Auxio_Canary.zip

from auxio.

Mischievous-Loner avatar Mischievous-Loner commented on August 15, 2024

This one too works for me.
Thoe I didn't notice any quality difference (maybe because of my trash display quality).
Do you still need crash logs from me?
Just a bit confused.

from auxio.

Book-reader avatar Book-reader commented on August 15, 2024

The album covers do look better in this version.

from auxio.

OxygenCobalt avatar OxygenCobalt commented on August 15, 2024

Okay, I'm going to consider this issue 'solved' for now.

from auxio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.