Coder Social home page Coder Social logo

get rid of jQuery UI about calendar HOT 13 OPEN

owncloud avatar owncloud commented on August 24, 2024
get rid of jQuery UI

from calendar.

Comments (13)

georgehrke avatar georgehrke commented on August 24, 2024

besides the dialog we also use a timepicker that requires jQuery UI.

@raghunayyar @jancborchardt Do you know of any good alternatives?

from calendar.

jancborchardt avatar jancborchardt commented on August 24, 2024

Can we simply use that part of jQuery UI? Or is the whole lib always needed?

cc @owncloud/designers do you know of any modern good timepicker library which also work on mobile?

from calendar.

georgehrke avatar georgehrke commented on August 24, 2024

Can we simply use that part of jQuery UI? Or is the whole lib always needed?

It requires jQuery UI core (whatever that is)
https://github.com/owncloud/calendar-rework/blob/master/js/vendor/jquery-timepicker/README.md#requirements

from calendar.

georgehrke avatar georgehrke commented on August 24, 2024

the jQuery UI dialogs are completely gone by now. The only thing left are the date and the time picker.

from calendar.

georgehrke avatar georgehrke commented on August 24, 2024

The core issue was rescheduled to ownCloud 9.1 This leaves us plenty of time here.
Postponing here as well.

from calendar.

raghunayyar avatar raghunayyar commented on August 24, 2024

Awesome, I will find an ng replacement for them this weekend.

from calendar.

georgehrke avatar georgehrke commented on August 24, 2024

Moving to 1.4, which will probably be our release to support 9.1

from calendar.

georgehrke avatar georgehrke commented on August 24, 2024

@jancborchardt What are the plans on the nextcloud side to drop jQuery UI?

from calendar.

jancborchardt avatar jancborchardt commented on August 24, 2024

Let’s see where we still use it:

  • LDAP settings: we can move away from the tab-based layout now that the settings are split into individual pages. cc @blizzz
  • The modal for the filepicker. Maybe we can just use that part.
  • The modal for accepting remote shares: Moved to the notifications area. cc @nickvergessen @schiessle
  • The Calendar app here.

Anything else I forgot? I would say we should get rid of it step by step. We can use individual aspects of it if we want, but maybe it is better to use the relevant components from Bootstrap instead as we already do with tipsy/tooltip.js

from calendar.

nickvergessen avatar nickvergessen commented on August 24, 2024

The modal for accepting remote shares

It's still used as a fallback, when notifications app is not enabled.

from calendar.

jancborchardt avatar jancborchardt commented on August 24, 2024

Instead of that as fallback, could we use the notification up top? @nickvergessen

from calendar.

blizzz avatar blizzz commented on August 24, 2024

LDAP settings: we can move away from the tab-based layout now that the settings are split into individual pages. cc @blizzz

We can talk about whether and how to change the layout. If it requires heavier changes, it's likely that it would slip to Nc 12. Anyway, the calendar repo is not the best place to track this…

from calendar.

jancborchardt avatar jancborchardt commented on August 24, 2024

@blizzz see nextcloud/server#1090 for the server issue

from calendar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.