Naming confusion about dataloader-php

[mcg-web]

No need to use promise adapter to create promise. Only requirement is to return a supported promise for the adapter you are using.

[akomm]

Thank you.

I still use the PromiseAdapterInterface, so my service does not need two adapters injected - its confusing ;)

But good to know.

[mcg-web]

Overblog\PromiseAdapter\PromiseAdapterInterface promise adapter is just an interface to help abstract Promises between different libs for dataloaders. GraphQL\Executor\Promise\PromiseAdapter has the same function but for graphql. GraphQL is not a requirements for this lib. When I introduce GraphQL\Executor\Promise\PromiseAdapter on graphql I try to make this a independent lib but was rejected :D

[akomm]

So you made instead of inheritance a composition to serve different adapters under the PromiseAdapterInterface so you are not dependend on a certain lib's interface.

When I use the WebonyxSync adapter as backend for the PromiseAdapterInterface, do I need to use it directly for the actual batchLoadFn result, or can I also use the PromiseAdapterInterface for the result of batchLoadFn? because the docs only tell "you need to return a promise".

I am a bit confused by this due to doc for the dataloader-bundle, which seem to use the GraphQL\Executor\Promise\PromiseAdapter for loader services results and Overblog\PromiseAdapter\PromiseAdapterInterface for the DataLoaders.

While I understand, that they both provide same base API, is there a reason to use two different adapters?