Conflict: usage of hasOwnProperty check gives coverage issues about hapi-contrib

[geek]

I don't think there is a mandate to use for...in, just that you should use it with objects:

Use for with arrays, for...in for objects

[danielb2]

But you can't use it with objects, and have 100% code coverage. You basically end up never ever using it at all. So I think the options are to either not using for...in or sometimes not having hasOwnProperty check. not using for...in is probably the safer and more consistent way.

[geek]

Is the code coverage not possible because the condition is always true for the object you are checking?

[danielb2]

Yes

var obj = {};

for (var key in obj) {
    if (!obj.hasOwnProperty(obj)) {
        continue;
    }
    // do things
}

the continue isn't ever reached here.

[geek]

Sounds reasonable to do what you suggested, just not require the hasOwnProperty for conditions like you describe. Maybe open a PR for the styleguide to make it more lenient.

[danielb2]

👍

[hueniverse]

I never use this style anymore. Always Object.keys() and simple for loop.