Comments (13)
I've been using 4
. Keep in mind that Travis uses nvm to install the appropriate node versions, so you can use whatever nvm accepts.
from hapi-contrib.
I think the answer mostly depends on the minimal node version that should be supported by modules. According to semver, minor versions may add functionality in a backwards-compatible manner. This means that the code which works on 4.0 will also work on 4.1, but the code which works on 4.1 may not work on 4.0 if it uses functionality that was added in 4.1.
So using 4 or 4.1 alone is not enough. 4 install the latest 4.x.x version, 4.1 installs the latest 4.1.x. Nothing guarantees that the code also runs on 4.0.x. Someone may accidentally use a feature in the code which was added in a minor version and it won't be caught by the test runner.
If the plan is to support all node versions starting from 4.0.0, then I think we should always run tests on the minimal minor version, which is 4.0. We can then add either 4 or 4.1 to make sure the code also works on the latest version. I see two options:
-
Run code on the minimal and the latest. Maintaining .travis.yml is easy this way.
node_js: - 0.10 - 4.0 - 4
-
Run code on each minor version starting from minimal. This ensures that the code works on all versions, but we would constantly need to update .travis.yml which is not an easy task given the number of modules the hapijs organization has.
node_js: - 0.10 - 4.0 - 4.1
I think the first version should be enough. It the code works on the minimal and the latest version, then it most likely will work on all versions between them.
However if there is no such minimal version requirement (the module should only work with the latest 4.x.x version), then using 4 in .travis.yml is enough.
from hapi-contrib.
Makes sense to me. +1
from hapi-contrib.
I agree with having "4.0" and "4" listed. Oldest and newest makes perfect sense.
from hapi-contrib.
Should it be 4 or 4.1 as the baseline since 4.1 is already out.
from hapi-contrib.
I guess it's just a question of what we want to support. If it's any 4.x release, then I think testing with "4.0" and "4.x" makes sense, since that covers the oldest possible 4.0 release, as well as the newest.
from hapi-contrib.
That makes sense to me.
from hapi-contrib.
4 and 4.0 it is.
from hapi-contrib.
That's good for now but I think once 4 LTS is released, we should not support 4.0 anymore, just the LTS.
from hapi-contrib.
Now the LTS is out shouldn't we revisit those versions and just support "4" and latest ("node" in nvm terms) ?
from hapi-contrib.
Probably.
from hapi-contrib.
yeah.. agreed, we should check LTS too. at least until we start using features that don't exist in LTS
from hapi-contrib.
I changed hapi to "4"
and "node"
.
from hapi-contrib.
Related Issues (20)
- listing extensions for individual modules on hapijs.com HOT 8
- Links for contacts are broken
- Link in Sponsorship.md is broken HOT 1
- Usage of github topics HOT 3
- Private repositories and users HOT 6
- Style guide: getters and hapi-scope-start HOT 2
- npm org and sharing access HOT 7
- State of the core module HOT 1
- New core contributor - Gil Pedersen HOT 6
- Indentation style question HOT 12
- How to handle package-lock.json? HOT 22
- Using var.ci ? HOT 3
- Utility modules should work on all supported node versions HOT 3
- Replace .npmignore with explicit `files: [ 'lib/' ]` in package.json? HOT 3
- Add takeover rules for modules with absent lead maintainer HOT 10
- BigInt support
- Add an explanation of the current desired CHANGELOG and release workflow
- Propose renaming "new contributor" label to "good first issue" HOT 4
- Additional tags in hapijs/discuss HOT 5
- Conflict in rules for object assignment HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hapi-contrib.