Coder Social home page Coder Social logo

Check how errors are shown about pidgin-otrng HOT 13 CLOSED

otrv4 avatar otrv4 commented on July 23, 2024
Check how errors are shown

from pidgin-otrng.

Comments (13)

claucece avatar claucece commented on July 23, 2024 1

@peterpalau This are the error messages:

  ERROR_1: (the message is undecryptable)
    Unreadable message
  ERROR_2: (the message arrived in a state that is not encrypted messages)
    Not in private state message
  ERROR_3: (the instance tags do not correspond)
    Malformed message

You can find the first one here:
https://github.com/otrv4/libotr-ng/blob/master/src/otrng.c#L1997 , when the flag is not set.

You can find the second one here:
https://github.com/otrv4/libotr-ng/blob/master/src/otrng.c#L2084, when the state is incorrect.

You can find the third one like here: https://github.com/otrv4/libotr-ng/blob/master/src/otrng.c#L1285, when the instance tags do not correspond.

from pidgin-otrng.

claucece avatar claucece commented on July 23, 2024 1

Hey @peterpalau ! I guess you solved it ;) Let me know if it still persists ;)

from pidgin-otrng.

claucece avatar claucece commented on July 23, 2024

@sahrosa

from pidgin-otrng.

claucece avatar claucece commented on July 23, 2024

Now that errors are actually handled by the plugin; we can recheck its information.

from pidgin-otrng.

olabini avatar olabini commented on July 23, 2024

We should just check that the text is proper and correct?

from pidgin-otrng.

claucece avatar claucece commented on July 23, 2024

Manly that when the error occurs, the error message is shown and it is the correct one. @olabini

from pidgin-otrng.

olabini avatar olabini commented on July 23, 2024

OK, make sense.

from pidgin-otrng.

claucece avatar claucece commented on July 23, 2024

These are the error messages: https://github.com/otrv4/otrv4/blob/master/otrv4.md#otr-error-messages


from pidgin-otrng.

claucece avatar claucece commented on July 23, 2024

The way error messages work is like this:

Alice sends a data message which has some kind of error. Bob receives it but instead of displaying it to the user, it sends an error message saying "hey your message had an error". Alice receives this error message and it gets displayed to her. You can see how they work here: https://github.com/otrv4/libotr-ng/blob/master/src/test/functionals/test_api.c#L568

from pidgin-otrng.

pedropalau avatar pedropalau commented on July 23, 2024

@claucece Maybe you know what about this error in libotr-ng?

pidgin: client.c:827: otrng_client_get_client_profile: Assertion `client->client_profile != NULL' failed.
Aborted (core dumped)

I know that when the assertion condition is false write out the result to stderr and then execute abort.

But why client->profile is NULL when client not.

from pidgin-otrng.

pedropalau avatar pedropalau commented on July 23, 2024

I found the reason or maybe how to solve this, is setting write/read permissions to the prekey-server-docker-compose folder.

from pidgin-otrng.

pedropalau avatar pedropalau commented on July 23, 2024

@claucece this is interesting.

If Alice send an unreadable message to Bob, which one is supposed to receive the following message?

You transmitted an unreadable message.

Even forcing the library to show the error OTRNG_ERROR_UNREADABLE_EVENT, this message appear to Bob when Alice is which wrote the message, and also this only occurs when the first message is sent, after that, Alice and Bob can continue writing each other normally.

I'm missing something?

from pidgin-otrng.

claucece avatar claucece commented on July 23, 2024

hey @peterpalau !

If Alice send an unreadable message to Bob, which one is supposed to receive the following message?

Alice. I have just tested and it shows up to Alice. See:

Sending (ssl) (alice@localhost/qb7N_w0s): <message type='chat' id='purplec801db87' to='bob@localhost'><active xmlns='http://jabber.org/protocol/chatstates'/><body>?OTR:AAQ126FP8QAAAAAAAAAFAAHboU/xAAIAEFpJyfW2AO87NHchqvYaPXx9leDN0wBEcryOEFO7wAtJoBhb4OtRXTtM2Bllx1PIhnMmwUtcy6rGAAADABJPZ0vY7kb8Ei4zTNwuBr7iN58Y/uWuilv8YDWv/95slD/WySN5yLaui5kn4AZjwI733lkKG/09cAAABAAAAAIzNAAFAAAAAF0M6AzCwZafB/62snJUsiWFp/VpNEuB80Z0XfbWdToA7dufaekcmEeyi4+kdGX3N6wXYjYmRQAjmZrr3gDs+rkfxsmybwLKo6SDitflMldXKVVi1VWwjmXtWP81pQsVPz56MG7oLrWVTrZ6HuBRAMquNALIIgA8gr//TccFgq5K5zS9JrsVhIwUGwBKG2BpsOpvPAPigbIIdY9Kza+cjuu3bN/wWETDglXPzAzenAAAAAGAeUl8P7pA/immbaf8gfB48dO/O11SH5uU/WRu2hRowVYG/Sn2eCiSbD14zBtEZe/VlZCov/JqLkdxCBcgLriyKsLLldNzN/FP4TjD7ZyjnM5yjk/yLC6rug+ShkjDHXM8aAE17iYbxuksxymmVI2Icwk64mtgKnZdfEsUOA7eneaQ0ZlDAhMlDiqflZrNAEAyhASKu8m+I7dRgNfmDz14RFBbCdW28Ak/97SCxHGsreVuHejXOVPH1ZVvtnaKlhkLo1y759r0NJTHMg1OWLo41ZQoegGUEphCHt9j3meBT9X8IuUtLQ32MLUrAEavvIWl9oc2mEDtEGS88uOXsYGfYauZPBYlapwbyqeD9wpvjqxnjWOm36rFbAZRmG9QdrvV3k73E8Fj/Q+yJb8ds+fcL5wCjNDWkl/38MKWKNEGROElVk/13FRAmglBz+PTokHIANZm/VCjtHL99DYYXih+d+mGh4P45Dzkdd2RyNvpRU0w0iTuHKywPbhRJK9m/NoI.</body></message>

(16:42:10) jabber: Recv (ssl)(210): <message to='alice@localhost' from='bob@localhost/3EI0rlcx' id='purpledb3ccb39' type='chat'><active xmlns='http://jabber.org/protocol/chatstates'/><body>?OTR Error: ERROR_3: OTRNG_ERR_MALFORMED</body></message>

Alice and Bob can continue writing each other normally.

Yeah, they should. Only one message is malformed. It does not mean that the rest will be.

from pidgin-otrng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.