otm / svg.math.js Goto Github PK

feature request: calc the point of Intersection

draw a horizontal or vertical line or any angle, to get the points of Intersection with paths

Typo in draw method of Line
https://github.com/otm/svg.math.js/blob/master/svg.math.js#L127

Hi,

I am doing some research on rectangles, and would like to create a Rectangle type. Would you like to add this type to svg.math.js? It will probably have methods such as: containsPoint, intersectsRect, etc.

Could you please add a LICENSE file to the repository so it is more clear how your code is licensed? Thanks!

In the move function, the sign for applying dy is the same as the sign for dx. A sign for dy should be calculated as well

Line 85

                            var radius = attr.radus || 5;

This seems like a typo.

Additionally, it is not clear what "attr" is. The argument is called "options".

If you use line.move() and the source and destination points are in a vertical line (i.e. both have the same x co-ordinate) then it moves in the wrong direction.

Example:
alert( new SVG.math.Line( new SVG.math.Point( 100, 100 ),
new SVG.math.Point( 100, 200 ) ).move(
new SVG.math.Point( 100, 100 ),
new SVG.math.Point( 100, 200 ), 10 ) .y );

Returns 90 (i.e. moving up) but should return 110 (moving down, along the line).