Coder Social home page Coder Social logo

Comments (15)

Otiel avatar Otiel commented on May 24, 2024

Can you provide an example URL?

from bandcampdownloader.

TadEro avatar TadEro commented on May 24, 2024

Oh okay, no problem.

Let's see, there's the Homestuck vol. 1-4 album.
It has this cover art.
The third track, Showtime (Original Mix), for instance, has this cover, wich is different from the album's.

Hope that helps!

from bandcampdownloader.

Otiel avatar Otiel commented on May 24, 2024

Thanks, I'll have a look at it.

from bandcampdownloader.

TadEro avatar TadEro commented on May 24, 2024

Okay! I hope you can implement it.

from bandcampdownloader.

TadEro avatar TadEro commented on May 24, 2024

I... I am still waiting for an update or something! :P

from bandcampdownloader.

Otiel avatar Otiel commented on May 24, 2024

I think the unwritten standard is to have a unique cover art for all songs of an album because the cover art replaces the album cover used on the front of a packaging audio product. I'm not too kind in changing the current way of doing.

The program sometimes applies them to their respective songs, and sometimes no.

Do you mean that BandcampDownloader sometimes saves a different cover art for some songs? Because it's not supposed to, and I couldn't reproduce it with the URL you provided.

from bandcampdownloader.

TadEro avatar TadEro commented on May 24, 2024

Well what I meant with that is, some songs have a different cover art than the "base" one.
What I also meant is that it's not the .jpg file of the album cover, but the individual cover each song has.

Here's another example; every track of this album has a different cover: Cherubim
I can give more if you'd like

from bandcampdownloader.

Otiel avatar Otiel commented on May 24, 2024

With this example Cherubim, only the album cover art is downloaded and tagged into each song. So BandcampDownloader behaves as it is supposed to.

I guess your sentence quoted below confused me, because I thought you were reporting a bug:

The program sometimes applies them to their respective songs, and sometimes no.

So are you reporting a bug, or are you just asking for a new feature that allows to download the individual songs cover art?

from bandcampdownloader.

TadEro avatar TadEro commented on May 24, 2024

well, technically both, since it doesn't work well. but yeah, it's a request. it would make me really happy to have this!

from bandcampdownloader.

Otiel avatar Otiel commented on May 24, 2024

Alright, I'll look into adding an option to download tracks art instead of the unique album art. 👌

from bandcampdownloader.

TadEro avatar TadEro commented on May 24, 2024

oh yes! thank you very much!

from bandcampdownloader.

ajsnyde avatar ajsnyde commented on May 24, 2024

@TadEro So the current way things are working on bandcamp, they essentially spit out a very easy-to-parse JSON string on most pages containing metadata about songs. This is how we get download links, title, lyrics, etc. When checking your example of a song with differing art, I couldn't find any property that would help us fetch the art.
What this means is that doing what you are asking will likely require a much different approach, code-wise. @Otiel , can you double-check for me to confirm what I'm saying?

from bandcampdownloader.

Otiel avatar Otiel commented on May 24, 2024

@ajsnyde There's no JSON property on the album page that links to the track art, but there is one on the track page, so we could do:

  1. Get track URL from album page (via title_link property).
  2. Download track page.
  3. Inside TralbumData variable of track page, get art_id property.
  4. Download track art (it's basically https://f4.bcbits.com/img/a[art_id]_10.jpg).

The drawback I see from this is we would need to download every track page (we don't know the need to download the track page because we can't even know in advance if the track art is different from the album art), and that will take a lot (I mean, a lot) more time.

from bandcampdownloader.

ajsnyde avatar ajsnyde commented on May 24, 2024

That was what I was worried about. Well, maybe I'll add something like that if I've got time.

from bandcampdownloader.

DarkVoyage avatar DarkVoyage commented on May 24, 2024

Would be nice, if BD could download originals of all additional artwork on page and also individual track images, even if takes a lot time to analyze. Take a look at this page and tracks - there are a lot of additional images: https://s1gnsofl1fe.bandcamp.com/album/language-of-the-ancients

I don't think you should add individual track images in tags, only the main image.

from bandcampdownloader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.