CoveragePkg: AddCross with IgnoreBin Error about osvvm

[JimLewis]

Hi Sebastian,
On travel. Hope to look at it today or tomorrow. That said, I don't like what I am hearing.

Best Regards,
Jim

[JimLewis]

Hi Sebastian,
Looks like a bug.

What follows is a work around. Build your ignore bins first, and then add your regular bins.

It can be done with either broad set of ignore bins

    AddCross(v_mycov2,IgnoreBin(3,4), ALL_COUNT) ;
    AddCross(v_mycov2,ALL_COUNT, IgnoreBin(7,8)); 
    AddCross(v_mycov2,GenBin(1,5),GenBin(6,10));

Or a focused set of ignore bins

    AddCross(v_mycov2,IgnoreBin(3,4), GenBin(6,10,1)) ;
    AddCross(v_mycov2,GenBin(1,5,1), IgnoreBin(7,8)); 
    AddCross(v_mycov2,GenBin(1,5),GenBin(6,10));

I will get to root cause later. It is time for Yoga.

Cheers,
Jim

[JimLewis]

Hi Sebastian,
First I improved the message so it prints which bins it did not like and your original test case prints:

# %% Alert  ERROR     in MyCov2,   CoveragePkg.InsertBin (AddBins/AddCross): ignore bin (3 to 4) (7)  dropped.  It is a subset of prior bin at 0 ns
# %% Alert  ERROR     in MyCov2,   CoveragePkg.InsertBin (AddBins/AddCross): ignore bin (3 to 4) (8)  dropped.  It is a subset of prior bin at 0 ns
# %% Alert  ERROR     in MyCov2,   CoveragePkg.InsertBin (AddBins/AddCross): ignore bin (3) (7 to 8)  dropped.  It is a subset of prior bin at 0 ns
# %% Alert  ERROR     in MyCov2,   CoveragePkg.InsertBin (AddBins/AddCross): ignore bin (4) (7 to 8)  dropped.  It is a subset of prior bin at 0 ns

These are clearly just overlapping ignore bins. The Alert there should have been a log DEBUG, so I changed it to that.

I have pushed this to the Dev branch.

Thanks for reporting the bug.

Cheers,
Jim

[JimLewis]

This is now fixed on the Dev branch

[SebDunst]

Hi Jim,
changing the log level from ERROR to DEBUG is certainly a good solution. But I do not understand why there is an overlapping issue at all? Where do the ignore bins overlap? (3,4) and (7,8).

Regards,
Sebastian