warnings/errors found by cppcheck about ossec-hids

[jrossi]

This is C and almost all memory leaks are an issue. This is something we care about a great deal and are very happy that we have more eyes looking into.

In this case I have not looked into the changes you create, but I would try them out and see if you run into problems. Another way is to run the process in valgrind and it will give you deep insight into how memory is used and if things are leaking. Using valgrind can take some time, but well worth learning if you plan on spending time in C.

If you feel this change is something that we should pull into OSSEC please open a pull require with the change set and we will review it.

I will attempt to checkout the change to see if I can give you any more input or suggestions.

[jrossi]

Just reviewing the code on a first pass. Looks like you are cleaning up some bugs. Thank you some of them have been around for ever.

I would like to make a suggestion that might make cleaning this up slightly simpler. Using a goto with and error: section for cleaning up. But i have not taken a deep look into the code yet.

[ChristianBeer]

Thanks for your response. I already refined my patch using a goto label. I will send a pull request once I'm ready. The downside is that I can't really test my changes other than compile the executables and see if it fails. Are you running test installations in a VM?

[jrossi]

Sorry did not noticed the question on the end. We do have some testing and we are adding more every day. Submit the pull request and we will test. Thank you again.

[jrossi]

Good day. I am watching you fork and looks like things have moved along nicely. Are you planning on creating that pull request? It is something I would very much like to see in Ossec. Thank you again.

[ChristianBeer]

Hi, yes I'm still planning on. Sadly I got ill and had some other unplanned things comming up. I'll look at this again next week when there is more time.

[jrossi]

Truly sorry to hear you got sick. Feel better. Thank you again.

[ChristianBeer]

The pull request got merged. I will rescan the codebase again and submit more findings directly as pull requests. Thank you for creating ossec.