Comments (8)
This is C and almost all memory leaks are an issue. This is something we care about a great deal and are very happy that we have more eyes looking into.
In this case I have not looked into the changes you create, but I would try them out and see if you run into problems. Another way is to run the process in valgrind and it will give you deep insight into how memory is used and if things are leaking. Using valgrind can take some time, but well worth learning if you plan on spending time in C.
If you feel this change is something that we should pull into OSSEC please open a pull require with the change set and we will review it.
I will attempt to checkout the change to see if I can give you any more input or suggestions.
from ossec-hids.
Just reviewing the code on a first pass. Looks like you are cleaning up some bugs. Thank you some of them have been around for ever.
I would like to make a suggestion that might make cleaning this up slightly simpler. Using a goto with and error: section for cleaning up. But i have not taken a deep look into the code yet.
from ossec-hids.
Thanks for your response. I already refined my patch using a goto label. I will send a pull request once I'm ready. The downside is that I can't really test my changes other than compile the executables and see if it fails. Are you running test installations in a VM?
from ossec-hids.
Sorry did not noticed the question on the end. We do have some testing and we are adding more every day. Submit the pull request and we will test. Thank you again.
from ossec-hids.
Good day. I am watching you fork and looks like things have moved along nicely. Are you planning on creating that pull request? It is something I would very much like to see in Ossec. Thank you again.
from ossec-hids.
Hi, yes I'm still planning on. Sadly I got ill and had some other unplanned things comming up. I'll look at this again next week when there is more time.
from ossec-hids.
Truly sorry to hear you got sick. Feel better. Thank you again.
from ossec-hids.
The pull request got merged. I will rescan the codebase again and submit more findings directly as pull requests. Thank you for creating ossec.
from ossec-hids.
Related Issues (20)
- sslv3 alert handshake failure
- Missing repo data for Ubuntu Jammy HOT 1
- /var/ossec/etc/ossec.conf and Ansible community.general.xml
- [HELP]
- Problem with decoders HOT 1
- ossec-analysisd leaks memory.
- Journald read in 1001 seconds bursts HOT 8
- Link doesn't exists
- Missing security policy. Cannot report security bugs and vulnerabilities. HOT 5
- Support for ossec in AmazonLinux2023 HOT 2
- 3.7 don;t have new files alerts HOT 2
- [Request] Provide binaries for arm64 Debian Bookworm/Trixie/Sid HOT 4
- Building from source on a staging server. How to transfer the build package to a production server? HOT 1
- Monitoring logs of journald not working
- ossec installation error HOT 1
- INSTALLATION OF OSSEC ERROR MAKEFILE:1017 HOT 3
- Wazuh agent not being initialized on RHEL and centos agents with the following error.
- OSSEC File Deletion not captured
- Ossec agent installation issue
- updates.atomicorp.com certificate expired HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ossec-hids.