[Feature Request] Refine InvalidGeometryCheck about atlas-checks

[Bentleysb]

This all sounds good to me. For the first item we could use the universal configurable tags.filter in the configuration (e.g. "tags.filter": "!roller_coaster").

[vladlemberg]

@Bentleysb, please assign this task to me.

[vladlemberg]

@atiannicelli, @Bentleysb, 1) done. for 2,3) im seeking for your suggestion. all validations for InvalidGeometryCheck occurs in GeometryValidation class, which also generating flag message. GeometryValidation works only with RawGeometry. It has to be refactored to work with Atlas objects (Area, Edge, etc..). Also GeometryValidation is used by other Checks as well.

[atiannicelli]

@vladlemberg Could you use GeometryValidator to indicate that issue and then just add to the error message that is returned? In other words:

instead of
"Geometry is Not Simple: Linear geometry intersecting itself at interior points (points other than the boundary)."
make it:
"Way 985261221 failed validity check: Geometry is Not Simple: Linear geometry intersecting itself at interior points (points other than the boundary). The way intersects with itself at [33.2643718, 44.4938849]"

f"{type} {osm_id} failed validity check: {reason} {intersecting points}"

You would need to do a little bit of work to get the intersecting points (or issue points) from each failing feature, but I think it would be best to do all of this in the check and not change the GeometryValidator

[atiannicelli]

I take it back. I just looked and I only see one other check using GeometryValidator. And that check doesn't use the error message - just the existence of an error message.
I personally would do as you suggested and refactor GeometryValidation to work with Atlas Objects and return an error message that is more detailed. But I'll let @Bentleysb comment.

[vladlemberg]

@Bentleysb, please close this issue.