Comments (5)
Should I also copy the git history?
from connector4java-integration-tests.
Yes, definitely!
from connector4java-integration-tests.
The self-administration integration-tests were already moved. The remaining tests are system integration tests for the connector and OSIAM. Just a few tests are not using the connector but a http client to test the OSIAM's REST endpoints directly. These tests should be moved to OSIAM.
Copy the git history and adjust OSIAM's pom was not a big deal. Bu the connector's and OSIAM's view on the SCIM classes (e.g. User and Group) are not the same. The tests are failing because the connector's ObjectMapper do not know about the jackson json filter which is used in OSIAM to filter attributes before sending the data back to the requester. But the tests need to use the connector's SCIM classes without the attribute filter.
There are several ways to deal with this problem:
- Move OSIAM's SCIM classes in a different package
- Move connector's SCIM classes in a different package
- Connector's ObjectMapper should not fail when the filter is not configured
- Just move integration tests to OSIAM which are not using the connector
from connector4java-integration-tests.
'3. Is working, because connector's ObjectMapper is public static. I can set OsiamConnector.objectMapper.setFilterProvider(new SimpleFilterProvider().setFailOnUnknownId(false));
in the static constructor of AbstractIT and AbstractIntegrationTestBase
I pushed my changes to my fork.
from connector4java-integration-tests.
thanks for your issue, but this repository will be archived.
from connector4java-integration-tests.
Related Issues (14)
- The test to search users with a complex query fails HOT 2
- Use the CircleCI cache for Maven dependencies
- Cache Docker images HOT 2
- Bring back verification of sent emails HOT 2
- Do not run mysql and postgresql on default ports
- Collect test metadata within Circle CI HOT 1
- Remove explicit installation of Docker 1.6.2 HOT 1
- Documentation for Docker Usage HOT 2
- Cross Project Debugging? HOT 6
- Remove tests of addon-self-administration
- Remove all old hashes from database seeds
- Migrate to Gradle HOT 1
- Migrate to CircleCI 2.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from connector4java-integration-tests.