Coder Social home page Coder Social logo

Comments (5)

dacrome avatar dacrome commented on August 26, 2024

Should I also copy the git history?

from connector4java-integration-tests.

wallner avatar wallner commented on August 26, 2024

Yes, definitely!

from connector4java-integration-tests.

dacrome avatar dacrome commented on August 26, 2024

The self-administration integration-tests were already moved. The remaining tests are system integration tests for the connector and OSIAM. Just a few tests are not using the connector but a http client to test the OSIAM's REST endpoints directly. These tests should be moved to OSIAM.

Copy the git history and adjust OSIAM's pom was not a big deal. Bu the connector's and OSIAM's view on the SCIM classes (e.g. User and Group) are not the same. The tests are failing because the connector's ObjectMapper do not know about the jackson json filter which is used in OSIAM to filter attributes before sending the data back to the requester. But the tests need to use the connector's SCIM classes without the attribute filter.

There are several ways to deal with this problem:

  1. Move OSIAM's SCIM classes in a different package
  2. Move connector's SCIM classes in a different package
  3. Connector's ObjectMapper should not fail when the filter is not configured
  4. Just move integration tests to OSIAM which are not using the connector

from connector4java-integration-tests.

dacrome avatar dacrome commented on August 26, 2024

'3. Is working, because connector's ObjectMapper is public static. I can set OsiamConnector.objectMapper.setFilterProvider(new SimpleFilterProvider().setFailOnUnknownId(false)); in the static constructor of AbstractIT and AbstractIntegrationTestBase

I pushed my changes to my fork.

from connector4java-integration-tests.

dacrome avatar dacrome commented on August 26, 2024

thanks for your issue, but this repository will be archived.

from connector4java-integration-tests.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.