Comments (3)
Comment by warmerdam on 22 May 2009 14:15 UTC
Unfortunately, I don't understand some of the entry points in PJ_lcc, and P->rho seems to be used in several of the functions. It is not at all clear it is a simple local that happens to have been put into the structure.
Also, this only puts full thread safety at risk - that is when multiple pj_fwd/pj_inv calls are being made on the same PJ object. With regard to thread safety I have traditionally been primarily concerned about safety when different threads are using distinct PJ objects which is not put at risk in this case.
I'm going to leave this open as a defect but I'm not expecting to take any immediate action.
from proj.
Comment by artwisz on 22 May 2009 15:02 UTC
I have removed the rho from the PJ structure, made rho a local variable and both forward and inverse transforms seem to be working. If you take a look at all control paths in the code, rho is always calculated before being used, so it need not be a structure member. Moreover, the LCC ENTRY (init) does not initialize rho at all, only rho0.
Generally, adding a const to the *pj parameter in the forward/inverse declarations is a good way to fish out all code where the structure is modified, which in this case is not thread safe. I am only using the LCC, so I don't know much about other projections.
from proj.
Comment by warmerdam on 24 Sep 2009 01:50 UTC
I concur with your analysis. I have removed rho from the structure in trunk (84d22b2e (SVN rev1629)).
from proj.
Related Issues (20)
- Transformation without Grid Shift HOT 1
- Transform X,Y,Z from source to dest with approximate Grid Shift HOT 3
- Controlling Grid Shifts (PROJ-data) size by selecting resolution HOT 3
- PROJJSON Schema redirect / CORS issues HOT 16
- geod should add cct's "-c" option, to finally allow it to also accept lon,lat input order HOT 1
- Support for EPSG methods 9666 and 1049 HOT 4
- Windows installer is broken HOT 2
- cct --help out of step with man cct, still shows "+step +step"
- `"-` artifact in rendered cct man page HOT 4
- Proposed enhancement for command-line interface tests HOT 3
- Ogr2ogr: Confusing error when source crs is unknown HOT 3
- GDA94 to GDA2020 horizontal shift fails when using EGM2008 & EGM96 vertical crs HOT 3
- Concatenated operation with height reversal fails HOT 2
- depth to depth or two CRS with orientation down issue? HOT 3
- Link PROJ to CMAKE HOT 3
- Transformation from Gauß Krüger (EPSG:31256) coordinates to WGS84 (EPSG:4326) ? HOT 2
- JOYr2
- Update to ESRI projection db available
- User writable directory HOT 2
- prj with "local" projection from ArcGIS HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proj.