Comments (5)
Comment by warmerdam on 18 May 2009 23:37 UTC
I have attempted to do the same thing slightly differently by removing the second operation (as a side effect inside another expression - ouch!) The change is in trunk (3a602739 (SVN rev1578)). I'd appreciate confirmation that this is appropriate and test data for this projection that I could add to the test suite.
from proj.
Comment by barendgehrels on 19 May 2009 07:44 UTC
I can confirm that the change is correct.
The "side effect" is also present in the line above. Actually they are a weird thing in C, embraced by some, rejected by others, and present in many more proj4 sources.
I don't know if you want to stay close to the original or branched versions, or that you want to refactor these constructs (making ports to other languages easier).
Where is the test suite?
from proj.
Comment by warmerdam on 19 May 2009 13:53 UTC
It is my wish to make minimal changes in the hopes that eventual merging with Gerald's fork will be easier. There is a modest test suite in the proj/nad directory (rather counter intuitive location I know!).
See proj/nad/testvarious
It is sufficient however if you can provide input, expected output and the coordinate system.
from proj.
Comment by barendgehrels on 19 May 2009 14:11 UTC
OK, I'm not familiar with those kinds of tests so limit myself indeed to the input/output:
(string, lon, lat, x, y, pars)
forward: ("kav5", 4.897000, 52.371000, 383646.088858, 5997047.888175, "+proj=kav5 +ellps=WGS84 +units=m");
(string, x, y, lon, lat, pars)
inverse: ("kav5", 383646.088858, 5997047.888175, 4.897000, 52.371000, "+proj=kav5 +ellps=WGS84 +units=m");
These x,y are '''not''' "the expected values", they are the ''proj4-calculated-values''. However, when applying then the inverse you might expect to get back a lon,lat pair which is close to the original input and that is what I checked.
If wished I can provide a proj4 testfile-in-C "checking" (in this way) all projections (I have it, with slight adaptions it is probably convenient).
Most projections are doing well, some have a difference of a few meters or kilometer, one of them is wrong (I contacted Gerald), one is still to be checked further.
from proj.
Comment by warmerdam on 19 May 2009 15:07 UTC
I have added in this test for kav5 in trunk along with a bit of restructuring (9de8a9b (SVN rev1579)).
from proj.
Related Issues (20)
- GDA94 to GDA2020 horizontal shift fails when using EGM2008 & EGM96 vertical crs HOT 3
- Concatenated operation with height reversal fails HOT 2
- depth to depth or two CRS with orientation down issue? HOT 3
- Link PROJ to CMAKE HOT 3
- Transformation from Gauß Krüger (EPSG:31256) coordinates to WGS84 (EPSG:4326) ? HOT 2
- JOYr2
- Update to ESRI projection db available
- User writable directory HOT 2
- prj with "local" projection from ArcGIS HOT 5
- Is this exception “osgeo::proj::io::FactoryException” a bug? in 9.4.0 HOT 8
- Minor version in libproj DLL suffix for MinGW HOT 2
- Geoid model list for a specific area HOT 5
- Proj4 export from a bound CRS object fails
- Interrupted Mollweide gives wrong result on inverse projections of some lat/lons. HOT 5
- .github/workflows/docker.yml to push only proj-docs for master pushes
- Project build failed on windows10 vs2017 HOT 1
- "proj_grid_info" C API function fails with grid "test_gridshift_projected.tif" HOT 4
- HEPOS GGRS87 shift grid HOT 2
- "No inverse method available" HOT 7
- Different (~100m) results from transforming WGS84 -> Belgian lambert 72 depending on definition used HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proj.