Allow -r flag to be used on single files about osfclient

[gedankenstuecke]

I have no strong opinions on this either way, but as the feature tries to emulate scp/rsync: In both you can do -r on single files I think, so allowing this here could lighten the mental load for users of osf-cli as the behaviour is identical?

[benlindsay]

I'm interested, and I might work on this when I get some time. I will not be offended if someone else starts one though

[betatim]

The thinking with giving an error was that chances are the user made a mistake if they specified -r and a single file. You think it is worth protecting people from that or outweighed by utility of being able to do what you did?

(Why didn't you do osf upload -r .? Which I would have expected to work, if not that is a bug IMHO)

[benlindsay]

In hindsight, osf upload -r . / would have worked fine, but I wanted some progress reporting, so the bash for loop was a hack to so I'd know which directory it got stuck on if there were errors (which there were, and which I posted under #74). I guess if progress reporting (ref #93) is working, there will be fewer cases where someone would intentionally use osf upload -r on a single file. The only case I can think of is in for loops similar to mine, which I could still see people using if they want to upload a subset of the files and directories in a given directory.

I do see your point though, that the -r with a single file could often mean someone didn't type the directory they actually wanted to upload. With that in mind, and with a -v option available in the future, I would be fine with this going either way.

[benlindsay]

I have no strong opinions on this either way, but as the feature tries to emulate scp/rsync: In both you can do -r on single files I think, so allowing this here could lighten the mental load for users of osf-cli as the behaviour is identical?

I tend to agree with this, especially if the plan is to make recursive uploads more scp-like or rsync-like, i.e. by allowing upload of multiple files or directories in one command instead of just allowing upload of one file or the contents of one directory. If that's not the plan, then maybe there's not much reason to make osf upload emulate other features of rsync and scp?

[betatim]

Should be a simple PR to remove the check and update the test. Go for it.

[betatim]

@benlindsay or @gedankenstuecke are either of you guys interested in creating a PR for this?

[gedankenstuecke]

Interested: Yes
Having time: Nope 😢

Sorry, will have to pass on that one.